Add per-provider enrich with userinfo endpoint setting#1445
Merged
julien-nc merged 3 commits intoMay 29, 2026
Conversation
Signed-off-by: s3n-w6i <37022952+s3n-w6i@users.noreply.github.com>
julien-nc
requested changes
May 28, 2026
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Nice PR, thanks.
- Backward compatibility 👍
- No migration needed 👍 because the value is stored in app config as a new row with the key
provider-N-enrichLoginIdTokenWithUserinfofor each provider
Signed-off-by: s3n-w6i <37022952+s3n-w6i@users.noreply.github.com>
julien-nc
approved these changes
May 29, 2026
testGetProvidersWithSettings: Since all boolean options are set to true by default, also set enrichLoginIdTokenWithUserinfo to true testSetSettings: Add missing enrichLoginIdTokenWithUserinfo field Signed-off-by: s3n-w6i <37022952+s3n-w6i@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This change introduces a checkbox into the provider settings that allows enabling the existing
enrich_login_id_token_with_userinfooption on a per-provider basis.To be backwards compatible, if the global
enrich_login_id_token_with_userinfois set to true, the userinfo endpoint is still fetched for all providers, regardless of their per-provider setting.Why
Open questions
enrichLoginIdTokenWithUserinfoon the provider's settings object. This does not require any database schema changes, right?