feat(sharing): Allow custom share tokens for public links#3348
Open
Chartman123 wants to merge 3 commits into
Open
feat(sharing): Allow custom share tokens for public links#3348Chartman123 wants to merge 3 commits into
Chartman123 wants to merge 3 commits into
Conversation
Chartman123
added
enhancement
susnux
reviewed
May 20, 2026
| $existingShare = $this->shareMapper->findPublicShareByHash($token); | ||
| if ($existingShare->getId() !== $formShare->getId()) { | ||
| $this->logger->debug('Share hash already exists.'); | ||
| throw new OCSBadRequestException('Share hash exists, please retry.'); |
Collaborator
There was a problem hiding this comment.
I think we should not leak that information
Suggested change
| throw new OCSBadRequestException('Share hash exists, please retry.'); | |
| throw new OCSBadRequestException('Invalid share token'); |
Chartman123
commented
May 21, 2026
Collaborator
Author
Chartman123
left a comment
Chartman123
left a comment
There was a problem hiding this comment.
@alexander-rebello I added some comments/suggestions. Most of them, especially the suggestions need the rebase on current main first.
| self::CONFIG_KEY_RESTRICTCREATION | ||
| ]; | ||
|
|
||
| public const PUBLIC_SHARE_TOKEN_MIN_LENGTH = 8; |
Collaborator
Author
There was a problem hiding this comment.
To be consistens with file sharing we should use 1 here, but we need to add bruteforce protection on the PageController
Comment on lines
+40
to
+42
| public function getAllowCustomPublicToken(): bool { | ||
| return json_decode($this->config->getAppValue($this->appName, Constants::CONFIG_KEY_ALLOWCUSTOMPUBLICTOKEN, 'false')); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
please use IAppConfig and getAppValueBool() here.
Suggested change
| public function getAllowCustomPublicToken(): bool { | |
| return json_decode($this->config->getAppValue($this->appName, Constants::CONFIG_KEY_ALLOWCUSTOMPUBLICTOKEN, 'false')); | |
| } | |
| public function getAllowCustomPublicToken(): bool { | |
| return json_decode($this->appConfig->getAppValueBool(Constants::CONFIG_KEY_ALLOWCUSTOMPUBLICTOKEN, false)); | |
| } |
Comment on lines
+88
to
+101
| <NcActionButton | ||
| v-if="appConfig.allowCustomPublicShareTokens" | ||
| :disabled=" | ||
| locked | ||
| || !isCurrentUserOwner | ||
| || isShareTokenSaving(share) | ||
| || !isShareTokenDirty(share) | ||
| " | ||
| @click="updateShareToken(share)"> | ||
| <template #icon> | ||
| <IconCheck :size="20" /> | ||
| </template> | ||
| {{ t('forms', 'Save token') }} | ||
| </NcActionButton> |
Collaborator
Author
There was a problem hiding this comment.
Value should be updated on input (with debounce).
Follow the implementation for file shares.
Code can be found here:
| import NcNoteCard from '@nextcloud/vue/components/NcNoteCard' | ||
| import NcTextField from '@nextcloud/vue/components/NcTextField' | ||
| import IconAccountMultiple from 'vue-material-design-icons/AccountMultipleOutline.vue' | ||
| import IconCheck from 'vue-material-design-icons/Check.vue' |
Collaborator
Author
There was a problem hiding this comment.
Use Material Symbol here
Suggested change
| import IconCheck from 'vue-material-design-icons/Check.vue' | |
| import IconCheck from '@material-symbols/svg-400/outlined/check.svg?raw' |
| NcIconSvgWrapper, | ||
| FormsIcon, | ||
| IconAccountMultiple, | ||
| IconCheck, |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| IconCheck, |
Comment on lines
303
to
305
| emits: ['addShare', 'updateShare', 'removeShare', 'update:formProp'], | ||
|
|
||
| setup() { | ||
| return { | ||
| FormsIcon, | ||
| IconCopyAll, | ||
| IconPlus, | ||
| IconCodeBrackets, | ||
| IconDelete, | ||
| IconLinkVariant, | ||
| IconLinkBoxVariantOutline, | ||
| IconAccountMultiple, | ||
| IconQr, | ||
| } | ||
| }, | ||
|
|
||
| data() { |
Collaborator
Author
There was a problem hiding this comment.
The icons need to be added to the setup().
Suggested change
| emits: ['addShare', 'updateShare', 'removeShare', 'update:formProp'], | |
| setup() { | |
| return { | |
| FormsIcon, | |
| IconCopyAll, | |
| IconPlus, | |
| IconCodeBrackets, | |
| IconDelete, | |
| IconLinkVariant, | |
| IconLinkBoxVariantOutline, | |
| IconAccountMultiple, | |
| IconQr, | |
| } | |
| }, | |
| data() { | |
| emits: ['addShare', 'updateShare', 'removeShare', 'update:formProp'], | |
| setup() { | |
| return { | |
| IconCheck, | |
| } | |
| }, | |
| data() { |
Comment on lines
35
to
+41
| <NcCheckboxRadioSwitch | ||
| ref="switchAllowCustomPublicShareTokens" | ||
| v-model="appConfig.allowCustomPublicShareTokens" | ||
| type="switch" | ||
| @update:modelValue="onAllowCustomPublicShareTokensChange"> | ||
| {{ t('forms', 'Allow custom public share tokens') }} | ||
| </NcCheckboxRadioSwitch> |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| <NcCheckboxRadioSwitch | |
| ref="switchAllowCustomPublicShareTokens" | |
| v-model="appConfig.allowCustomPublicShareTokens" | |
| type="switch" | |
| @update:modelValue="onAllowCustomPublicShareTokensChange"> | |
| {{ t('forms', 'Allow custom public share tokens') }} | |
| </NcCheckboxRadioSwitch> | |
| <NcCheckboxRadioSwitch | |
| v-model="appConfig.allowCustomPublicShareTokens" | |
| :loading="loading.allowCustomPublicShareTokens" | |
| type="switch" | |
| @update:modelValue="onAllowCustomPublicShareTokensChange"> | |
| {{ t('forms', 'Allow custom public share tokens') }} | |
| </NcCheckboxRadioSwitch> |
Comment on lines
+125
to
131
| async onAllowCustomPublicShareTokensChange(newVal) { | ||
| const el = this.$refs.switchAllowCustomPublicShareTokens | ||
| el.loading = true | ||
| await this.saveAppConfig('allowCustomPublicShareTokens', newVal) | ||
| el.loading = false | ||
| }, | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| async onAllowCustomPublicShareTokensChange(newVal) { | |
| const el = this.$refs.switchAllowCustomPublicShareTokens | |
| el.loading = true | |
| await this.saveAppConfig('allowCustomPublicShareTokens', newVal) | |
| el.loading = false | |
| }, | |
| async onAllowCustomPublicShareTokensChange(newVal) { | |
| this.loading.allowCustomPublicShareTokens= true | |
| await this.saveAppConfig('allowCustomPublicShareTokens', newVal) | |
| this.loading.allowCustomPublicShareTokens= false | |
| }, | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2815
This adds admin-gated custom tokens for public Forms share links. By default the feature is disabled, so existing instances keep the current random-token behavior. When enabled by an admin, form owners can edit the token of an existing public link directly in the sharing sidebar, save it explicitly, and the old URL becomes invalid immediately.
It also adds the necessary backend support for token updates, keeps public-link routing compatible with custom tokens, and includes tests plus API documentation updates.
New PR replacing #3311