fix(oc-capability): uses correct room field types#16781
Open
alperozturk96 wants to merge 2 commits intomasterfrom
Open
fix(oc-capability): uses correct room field types#16781alperozturk96 wants to merge 2 commits intomasterfrom
alperozturk96 wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/23749644834/artifacts/6180479612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
forbiddenFileNameCharacters, forbiddenFileNames, forbiddenFileNameExtensions, forbiddenFilenameBaseNamesThis PR fixes an inconsistency where several capabilities columns were defined as
INTEGERinRoombut actually storedJSONStringvalues.Why it previously worked
Data was read via cursor (getString), bypassing Room’s type mapping
Changes
Updated affected fields in
CapabilityEntityfromInt?toString?Added a migration that drops the capabilities table to ensure a clean schema
Adds capability dao and mapping between entity and
OCCapability