Skip to content

feat: add AWSEKSNODEGROUP entity type (NR-604119) - #3200

Merged
davidgonzalez-nr merged 3 commits into
newrelic:mainfrom
rkumarregar:nr-604119-eks-nodegroup-entity
Sep 16, 2026
Merged

davidgonzalez-nr merged 3 commits into
newrelic:mainfrom
rkumarregar:nr-604119-eks-nodegroup-entity

Conversation

@rkumarregar

@rkumarregar rkumarregar commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

New INFRA entity type for AWS EKS Nodegroups, mirroring the minimal AWSEC2VPC/AWSEC2SUBNET shape exactly (no synthesis block -- registered directly by aws-configuration-fetcher via CFT-scan discovery + CloudControl, not inferred from telemetry events; alertable: false, no golden/summary metrics -- CloudWatch metric-stream support for EKS Nodegroups is not being added in this pass, so there's nothing to chart yet).

Lets aws-configuration-fetcher (1) register Nodegroup as a real entity when discovered via CFT scan, and (2) resolve a real GUID for it as the target of a Cluster->Nodegroup candidate relationship, matching the existing Cluster->VPC/Subnet pattern (see aws-configuration-fetcher PR https://source.datanerd.us/beyond/aws-configuration-fetcher/pull/377).

Validated locally: npm run check in validator/ passes clean.

Relevant information

Api Review Board (ARB)

Pull requests with changes to this repository might need to be linked with an ARB ticket, which has to be approved before merging.

If you are an external contributor please contact New Relic Support.

What definition changes require ARB and which do not? Guide here.

If you are new to ARB process also check this.

ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-610550

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.
  • I've linked an ARB ticket & received approval from API Review Board in order to make these changes

New INFRA entity type for AWS EKS Nodegroups, mirroring the minimal
AWSEC2VPC/AWSEC2SUBNET shape exactly (no synthesis block -- registered
directly by aws-configuration-fetcher via CFT-scan discovery + CloudControl,
not inferred from telemetry events; alertable: false, no golden/summary
metrics -- CloudWatch metric-stream support for EKS Nodegroups is not being
added in this pass, so there's nothing to chart yet).

Lets aws-configuration-fetcher (1) register Nodegroup as a real entity when
discovered via CFT scan, and (2) resolve a real GUID for it as the target of
a Cluster->Nodegroup candidate relationship, matching the existing
Cluster->VPC/Subnet pattern (see aws-configuration-fetcher PR
https://source.datanerd.us/beyond/aws-configuration-fetcher/pull/377).

Validated locally: `npm run check` in validator/ passes clean.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot
entityBot requested a review from a team August 26, 2026 12:35
rpaliwal1997
rpaliwal1997 previously approved these changes Aug 26, 2026

@rpaliwal1997 rpaliwal1997 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@entityBot
entityBot requested a review from a team August 26, 2026 13:10
@entityBot
entityBot dismissed stale reviews from rpaliwal1997 and themself September 14, 2026 06:04

Dismissing reviews

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • ARB tickets not approved: NR-610550 (Status: In Review).
    The review process is not handled by Entity Platform, reach #api-review-board channel in case of doubts

@entityBot
entityBot requested review from a team and removed request for a team September 14, 2026 06:05

@akifullahkhan-png akifullahkhan-png left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@entityBot
entityBot requested a review from a team September 14, 2026 06:07
@entityBot
entityBot requested review from a team and removed request for a team September 16, 2026 09:07

@rpaliwal1997 rpaliwal1997 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@entityBot
entityBot requested a review from a team September 16, 2026 09:54
@davidgonzalez-nr
davidgonzalez-nr merged commit 39023aa into newrelic:main Sep 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants