Conversation
|
|
entityBot
previously requested changes
Aug 21, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
jashraf-hash
marked this pull request as draft
August 21, 2026 05:47
jashraf-hash
marked this pull request as ready for review
August 24, 2026 10:24
entityBot
previously requested changes
Aug 24, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
entityBot
previously requested changes
Aug 24, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
entityBot
previously requested changes
Aug 26, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
…//github.com/jashraf-hash/entity-definitions into NR-601870-api-gateway-logs-entity-syntheisis
entityBot
previously requested changes
Aug 28, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
entityBot
previously requested changes
Sep 1, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
jashraf-hash
changed the title
sseif-nr
reviewed
Sep 3, 2026
sseif-nr
reviewed
Sep 3, 2026
Collaborator
|
What is the e2e coverage for the proposed new features? |
entityBot
previously requested changes
Sep 7, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- ARB tickets not approved: NR-613181 (Status: Pending Response).
The review process is not handled by Entity Platform, reach#api-review-boardchannel in case of doubts
Contributor
Author
We will be testing end to end and need your approval for deploy in staging.We hope to cover it 100% |
entityBot
requested changes
Sep 10, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- Error PARSING domainType: 'infra-ocicloudevents' on entitydefinitionemitter.models.BaseEntityDefinition - jackson.databind.exc.ValueInstantiationException: Cannot construct instance of
entitydefinitionsclientsynthesis.models.definitions.EntitySynthesisRule, problem: must contain a condition
at [Source: (StringReader); line: 35, column: 4] (through reference chain: entitydefinitionemitter.models.BaseEntityDefinition["synthesis"]->entitydefinitionemitter.models.CustomEntitySynthesisRules["rules"]->ArrayList[1])
entityBot
approved these changes
Sep 10, 2026
maya-jha
previously approved these changes
Sep 10, 2026
entityBot
previously approved these changes
Sep 10, 2026
Collaborator
|
👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/BEYOND Please review or provide an update. |
…//github.com/jashraf-hash/entity-definitions into NR-601870-logs-entity-syntheisis
entityBot
approved these changes
Sep 16, 2026
maya-jha
previously approved these changes
Sep 16, 2026
entityBot
approved these changes
Sep 17, 2026
entityBot
approved these changes
Sep 18, 2026
entityBot
approved these changes
Sep 21, 2026
entityBot
approved these changes
Sep 21, 2026
pbhadra0112
approved these changes
Sep 21, 2026
shivanikash
approved these changes
Sep 21, 2026
bgalmesnr
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant information
This PR adds entity synthesis definitions for API Gateway as part of the broader OCI entity expansion initiative.
Summary of work completed:
Collected raw logs for API Gateway, Network Load Balancer, VCN, and Network Firewall.
Analyzed payloads and created entity synthesis rules based on the spike documentation (Spike Document Reference).
Evaluated payload coverage across services currently being processed by metrics (including Object Storage, DNS, Database, Integration, and others).
Confirmed below doing testing via different oci payloads calling nr api .
a)Both identifier and name field required for entity synthesis
b)If we dont pass name field but pass OCID as identifier, event doesnot get attached to entity.
c)If we pass identifier and name field and if name field changes in payload from previously sent logs for same identifier ,then name is updated for entity
At present,its confirmed that we can take API Gateway for entity synthesis from logs side to production.
Api Review Board (ARB)
ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-613181
Checklist
[x] I've read the guidelines and understand the acceptance criteria.
[x] The value of the attribute marked as identifier will be unique and valid.
[x] I've confirmed that my entity type wasn't already defined.
[x] I've linked an ARB ticket & received approval from API Review Board in order to make these changes