Skip to content

Lambda function is created with invalid environment variable name. #60

Description

@shinji-newrelic

In the code, environment variable with name S3_CLOUDTRAIL_LOG_PATTERN is read from environment variables.

https://github.com/newrelic/aws_s3_log_ingestion_lambda/blob/master/src/handler.py#L107

However if this is deployed from AWS Serverless Application Repository, the environment variable S3_CLOUD_TRAIL_LOG_PATTERN is defined.
("_" is inserted between "CLOUD" and "TRAIL")

https://github.com/newrelic/aws_s3_log_ingestion_lambda/blob/master/template.yml#L91
https://github.com/newrelic/aws_s3_log_ingestion_lambda/blob/master/template.yml#L128

This may introduce miss configuration by the users. They should have same environment variable name.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions