Skip to content

Change API logic to handle multiple parents#52

Draft
HenryCrosswell wants to merge 33 commits into
mainfrom
hc/api-more-than-two-parents
Draft

Change API logic to handle multiple parents#52
HenryCrosswell wants to merge 33 commits into
mainfrom
hc/api-more-than-two-parents

Conversation

@HenryCrosswell

Copy link
Copy Markdown

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Previous api pulls when multiple parents (1 male and 2 females) are involved would break the request

What does this PR do?
This pull request swaps hardcoded parents with dynamically numbered parents, so that any amount of parent data can be handled. Changes API request logic away from individual parents and combines them together as one request.

References

Progress towards issue #23

How has this PR been tested?

Yes, all tests pass with updated gin repo

Is this a breaking change?

Yes, as the standardisation changes are yet to be implemented, they will not currently work with the changes.

Does this PR require an update to the documentation?

Not yet

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Henry Crosswell added 30 commits June 11, 2026 09:14
…rk, refactored column renaming into own func
…ull mutations for all parent_sex once, adjusted other functions to fit
Merged with upstream main, to include pypi naming changes
@HenryCrosswell HenryCrosswell requested a review from a team July 1, 2026 11:14
@HenryCrosswell HenryCrosswell self-assigned this Jul 1, 2026
@HenryCrosswell HenryCrosswell changed the title Hc/api more than two parents Change API logic to handle multiple parents Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant