Skip to content

Fix linkcheck errors#84

Merged
niksirbi merged 6 commits into
mainfrom
fix-linkcheck-errors
Jul 2, 2026
Merged

Fix linkcheck errors#84
niksirbi merged 6 commits into
mainfrom
fix-linkcheck-errors

Conversation

@niksirbi

@niksirbi niksirbi commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Linkcheck was failing across dozens of links, blocking CI for in-progress PRs.

What does this PR do?

Deals with all the broken links via one of 3 strategies:

  1. Most broken links were due to GIN. Here I chose to completely linkcheck-ignore GIN as it's often flaky (frequently goes offline)
  2. A few broken links were leading to journal manuscripts. I replaced those with their permanent doi identifier links (which will not break), manually verified that the updated links resolve, and then added doi.org to the linkcheck ignore list (access to doi links is usually rate limited or completely blocked).
  3. Some links (mostly to documentation sites) had genuinely changed and I updated those to new targets. I could no longer find the documentation site for SpikeForest, so I chose to link to the GitHub repo in that case.

References

Unblocks #81 and #80

How has this PR been tested?

Local linckheck run, CI, and manually checking the links from categories 2 and 3 above.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

N/A

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@niksirbi niksirbi requested a review from adamltyson July 2, 2026 10:49
@niksirbi niksirbi marked this pull request as ready for review July 2, 2026 10:49

@adamltyson adamltyson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few suggestions.

Comment thread docs/source/electrophysiology/resources.md Outdated
Comment thread docs/source/electrophysiology/resources.md Outdated
niksirbi and others added 2 commits July 2, 2026 13:36
Co-authored-by: Adam Tyson <code@adamltyson.com>
Co-authored-by: Adam Tyson <code@adamltyson.com>
@niksirbi niksirbi merged commit 6bbc207 into main Jul 2, 2026
3 checks passed
@niksirbi niksirbi deleted the fix-linkcheck-errors branch July 2, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants