NETOBSERV-2872 change feature columns defaults for views by memodi · Pull Request #2836 · netobserv/netobserv-operator

memodi · 2026-07-01T16:30:01Z

Description

change feature columns defaults for views now since those columns will be preset in feature specific view and All Traffic column will only show default base columns.

Dependencies

netobserv/netobserv-web-console#1595

Checklist

Does the changes in PR need specific configuration or environment set up for testing?
- if so please describe it in PR description.
I have added thorough unit tests for the change.
QE requirements (check 1 from the list):
- Standard QE validation, with pre-merge tests unless stated otherwise.
- Regression tests only (e.g. refactoring with no user-facing change).
- No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Co-Authored-By: Claude Sonnet.

Summary by CodeRabbit

User Experience
- Updated default network and connection table settings to show fewer columns initially.
- Applied consistent defaults across source and destination network details.

openshift-ci · 2026-07-01T16:30:05Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-07-01T16:30:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-07-01T16:30:09Z

📝 Walkthrough

Walkthrough

The static frontend configuration no longer enables nine network and flow metadata columns by default. Source and destination column settings were updated consistently.

Changes

Frontend column defaults

Layer / File(s)	Summary
Disable selected column defaults `internal/controller/consoleplugin/config/static-frontend-config.yaml`	Network Name, TLS Version, DNS Latency, DNS Response Code, Flow RTT, Network Events, Xlat Zone ID, translated Kubernetes Objects, and IPsec Status are no longer enabled by default.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the change to default feature columns for views.
Description check	✅ Passed	The description explains the behavior change, lists the dependency, and includes the required checklist with QE selection.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

memodi · 2026-07-06T13:30:31Z

/ok-to-test

github-actions · 2026-07-06T13:34:17Z

New images:

quay.io/netobserv/network-observability-operator:d816ecd1
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d816ecd1
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d816ecd1

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:d816ecd1 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d816ecd1

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d816ecd1
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

memodi · 2026-07-22T12:32:17Z

/ok-to-test

github-actions · 2026-07-22T12:35:44Z

New images:

quay.io/netobserv/network-observability-operator:d816ecd1
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d816ecd1
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d816ecd1

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:d816ecd1 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d816ecd1

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d816ecd1
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

github-actions · 2026-07-22T12:39:05Z

New images:

quay.io/netobserv/network-observability-operator:d816ecd1
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d816ecd1
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d816ecd1

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:d816ecd1 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d816ecd1

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d816ecd1
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/controller/consoleplugin/config/static-frontend-config.yaml`:
- Line 178: Update the user-facing documentation for the default UI columns
affected by the configuration entries in the static frontend config, including
the feature-specific view behavior. Ensure the documented defaults match the
changed values and cover all related entries, including the configuration around
the default setting shown here.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d53f59b8-4439-41e9-b789-bea280a5161e

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd5473 and 52a7fc8.

📒 Files selected for processing (1)

internal/controller/consoleplugin/config/static-frontend-config.yaml

coderabbitai · 2026-08-04T23:07:53Z

    field: SrcK8S_NetworkName
    filter: src_network
-    default: true
+    default: false


📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Document the changed default-column behavior.

These changes alter the columns shown by default in the UI. Add or update user-facing documentation for the new defaults and the feature-specific view behavior.

As per coding guidelines, update documentation when changing user-facing behavior.

Also applies to: 319-319, 440-440, 614-614, 623-623, 640-656, 681-681, 706-706, 721-721

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@internal/controller/consoleplugin/config/static-frontend-config.yaml` at line 178, Update the user-facing documentation for the default UI columns affected by the configuration entries in the static frontend config, including the feature-specific view behavior. Ensure the documented defaults match the changed values and cover all related entries, including the configuration around the default setting shown here.

Source: Coding guidelines

jpinsonneau

Looks good; don't forget to update the plugin sample with the script https://github.com/netobserv/netobserv-web-console/blob/main/scripts/update-config.sh

codecov · 2026-08-05T08:27:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (5fd5473) to head (52a7fc8).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #2836   +/-   ##
============================
============================

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

memodi · 2026-08-05T13:34:58Z

Looks good; don't forget to update the plugin sample with the script https://github.com/netobserv/netobserv-web-console/blob/main/scripts/update-config.sh

thanks, yes, the change is already in PR netobserv/netobserv-web-console#1595

memodi · 2026-08-06T14:20:54Z

/ok-to-test

github-actions · 2026-08-06T14:24:28Z

New images:

quay.io/netobserv/network-observability-operator:52a7fc8d
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-52a7fc8d
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-52a7fc8d

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:52a7fc8d make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-52a7fc8d

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-52a7fc8d
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

github-actions · 2026-08-21T16:03:20Z

New images:

quay.io/netobserv/network-observability-operator:52a7fc8d
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-52a7fc8d
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-52a7fc8d

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:52a7fc8d make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-52a7fc8d

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-52a7fc8d
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Amoghrd · 2026-08-21T17:41:25Z

/ok-to-test

github-actions · 2026-08-21T17:44:55Z

New images:

quay.io/netobserv/network-observability-operator:52a7fc8d
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-52a7fc8d
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-52a7fc8d

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:52a7fc8d make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-52a7fc8d

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-52a7fc8d
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Amoghrd · 2026-08-21T19:08:35Z

+    default: false
    width: 10
    feature: tlsTracking
  - id: TLSCipherSuite


Any reason why TLSCipherSuite, TLSGroup and TLSTypes columns dont have default:false?

if its not set, then it would resolve as false when unmarshalling yaml.

Then can just remove all defaults instead of setting to false here

I think its okay to leave existing fields as is.

openshift-ci Bot added the do-not-merge/work-in-progress label Jul 1, 2026

memodi mentioned this pull request Jul 1, 2026

NETOBSERV-2872 feature views netobserv/netobserv-web-console#1595

Open

6 tasks

openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 6, 2026

memodi removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 22, 2026

openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 22, 2026

memodi changed the title ~~change feature columns defaults for views~~ NETOBSERV-2872 change feature columns defaults for views Jul 28, 2026

change feature columns defaults for views

52a7fc8

memodi force-pushed the views branch from d816ecd to 52a7fc8 Compare August 4, 2026 23:04

github-actions Bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 4, 2026

memodi marked this pull request as ready for review August 4, 2026 23:04

openshift-ci Bot removed the do-not-merge/work-in-progress label Aug 4, 2026

memodi requested review from jotak and jpinsonneau August 4, 2026 23:04

coderabbitai Bot reviewed Aug 4, 2026

View reviewed changes

jpinsonneau approved these changes Aug 5, 2026

View reviewed changes

openshift-ci Bot assigned jpinsonneau Aug 5, 2026

openshift-ci Bot added the lgtm label Aug 5, 2026

openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 6, 2026

memodi added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Aug 21, 2026

Amoghrd removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 21, 2026

openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 21, 2026

Amoghrd reviewed Aug 21, 2026

View reviewed changes

Uh oh!

Conversation

memodi commented Jul 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

coderabbitai Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

memodi commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

memodi commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

jpinsonneau left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

memodi commented Aug 5, 2026

Uh oh!

memodi commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

Amoghrd commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

Amoghrd Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

memodi Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

Amoghrd Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

memodi Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

memodi commented Jul 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 1, 2026 •

edited

Loading

codecov Bot commented Aug 5, 2026 •

edited

Loading