Repository navigation
Fixes #85: Restore object selector and Quick add dialogs on the Script Run page - #90
Merged
jnovinger merged 1 commit intoOct 30, 2026
Conversation
The Run page extended a base template with an empty modals block, so the Open selector and Quick add buttons of an object field had no dialog to open. The page now includes the shared htmx modal, as the built-in Script page does. Fixes #85
pheus
marked this pull request as ready for review
October 30, 2026 12:22
jnovinger
approved these changes
Oct 30, 2026
jnovinger
deleted the
85-object-selector-and-quick-add-do-not-open-on-the-script-run
branch
October 30, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #85
The object selector and Quick add buttons could not open their dialogs on the Script Run page. The page now includes NetBox's shared modal, matching the built-in Script page.
Adds a regression test checking that both buttons and their required modal elements are present.