Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
A Script's own exception from its constructor or run form now reaches NetBox's error handling unchanged on the Run tab, the REST run action and runcustomscript. Each of them catches load failures only while it loads the class, and the revision's import context still spans the form. Fixes #17
pheus
force-pushed
the
17-errors-in-custom-script-forms-are-reported-as-source-loading
branch
from
October 29, 2026 14:56
a0edcbb to
3178959
Compare
pheus
marked this pull request as ready for review
October 29, 2026 15:37
jnovinger
approved these changes
Oct 29, 2026
jnovinger
deleted the
17-errors-in-custom-script-forms-are-reported-as-source-loading
branch
October 29, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17
Errors from a Script's constructor or run form are no longer reported as source-loading failures. The Run tab, REST run action and
runcustomscriptnow preserve the original exception, while keeping the revision loaded throughout form processing.