Repository navigation
Fixes #16: Describe FileVar multipart uploads in the run schema - #70
Merged
jnovinger merged 1 commit intoOct 29, 2026
Merged
Conversation
The run action's OpenAPI schema now declares a separate multipart body. Its data field is a JSON object encoded as a string, and each FileVar upload is a binary part named after its variable. The JSON body and the runtime validation are unchanged. Fixes #16
pheus
marked this pull request as ready for review
October 29, 2026 13:26
jnovinger
approved these changes
Oct 29, 2026
| ) | ||
|
|
||
|
|
||
| class NetBoxScriptRunMultipartInputSerializer(NetBoxScriptRunInputSerializer): |
Member
There was a problem hiding this comment.
As long as I'm not required to remember this name 😛
jnovinger
deleted the
16-the-rest-run-schema-does-not-describe-filevar-multipart
branch
October 29, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16
The run schema reused the JSON request definition for multipart requests, leaving
FileVaruploads undocumented. This adds a separate multipart schema withdataas a JSON object encoded as a string and uploads as binary parts named after their variables.Schema tests cover both request formats and their shared run parameters.