Add ICurrentApp to expose the current app id to apps - #1442
Open
zyga69 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
====================================
- Coverage 83% 82% -1%
====================================
Files 201 201
Lines 4162 4165 +3
Branches 485 485
====================================
- Hits 3460 3455 -5
- Misses 497 504 +7
- Partials 205 206 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Apps and services resolved in an app's DI scope had no supported way to find out which app they belong to. The only object carrying that information, ApplicationContext, is internal. Add a small read-only ICurrentApp interface exposing the app id, and register the existing scoped ApplicationContext as its implementation. This lets an app inject ICurrentApp (or resolve it from any service in its scope) to select per-app configuration, logging, etc. IApplication is not reused for this because it also exposes lifecycle methods that apps should not call on themselves.
zyga69
force-pushed
the
feat/current-app-id
branch
from
September 1, 2026 14:03
1dd0a99 to
68874d2
Compare
helto4real
approved these changes
Sep 1, 2026
helto4real
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution.
Collaborator
|
@zyga69 can you make sure you have commit that have verified signature, it is a security measure, just fix it and foce push and we are golden. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Apps and services resolved in an app's DI scope had no supported way to find out which app they belong to. The only object carrying that information, ApplicationContext, is internal.
Add a small read-only ICurrentApp interface exposing the app id, and register the existing scoped ApplicationContext as its implementation. This lets an app inject ICurrentApp (or resolve it from any service in its scope) to select per-app configuration, logging, etc. IApplication is not reused for this because it also exposes lifecycle methods that apps should not call on themselves.
Type of change
Additional information
Checklist
If user exposed functionality or configuration are added/changed: