fix(swc): do not inherit watch mode when transpiling newly added files - #3483
Open
higuaifan wants to merge 1 commit into
Open
fix(swc): do not inherit watch mode when transpiling newly added files#3483higuaifan wants to merge 1 commit into
higuaifan wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The "transpile newly added file" callback in the swc builder re-invokes
swcCli.default()withwatch: trueinherited from the outer options. Per added file (renames and git checkouts count — atomic writes surface asadd), this registers one more permanent chokidar watcher inside@swc/cli(stacked watchers → duplicate compiles and back-to-back restarts) and constructs one more Piscina worker pool that@swc/clinever destroys (swc-project/pkgs#126) — a week-long watch session accumulated ~1,700 idle worker threads / ~15 GB.Issue Number: #3482
What is the new behavior?
The added-file invocation is one-shot:
watch: falsestops the watcher stacking, andsync: trueskips spawning a worker pool to transpile a single file. Unit test added.Does this PR introduce a breaking change?
This PR — investigation, patch, test, and local CI verification — was engineered by Claude; I'm following up and available for changes if wanted.