Performance optimizations for the compartmental feature (PR for merge) - #1388
Open
LeanderEwert wants to merge 554 commits into
Open
Performance optimizations for the compartmental feature (PR for merge)#1388LeanderEwert wants to merge 554 commits into
LeanderEwert wants to merge 554 commits into
Conversation
…origin/LeanderEwert
# Conflicts: # setup.py
…tion # Conflicts: # pynestml/cocos/co_cos_manager.py # pynestml/codegeneration/printers/nest_variable_printer.py # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_compartmentcurrents_@NEURON_NAME@.cpp.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_compartmentcurrents_@NEURON_NAME@.h.jinja2 # pynestml/utils/ast_mechanism_information_collector.py # pynestml/utils/mechanism_processing.py # pynestml/utils/syns_info_enricher.py
…us input handler hijacked for testing. No extensive testing done.
Also consectutive area -wise processing implemented.
Modifications to main vector loop.
…anent zero output and added error message when passing a parameter to the compartment creation that doesn't exist in the model.
…erEwert_vectorization
…m_optimized_merge_prepare # Conflicts: # pynestml/codegeneration/nest_compartmental_code_generator.py # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_neuroncurrents_@NEURON_NAME@.cpp.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_neuroncurrents_@NEURON_NAME@.h.jinja2 # pynestml/utils/mechs_info_enricher.py
# Conflicts: # pynestml/codegeneration/nest_compartmental_code_generator.py # pynestml/codegeneration/resources_nest/point_neuron/directives_cpp/FunctionDeclaration.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/@NEURON_NAME@.cpp.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/@NEURON_NAME@.h.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_directives_cpp/Declaration.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_directives_cpp/PredefinedFunction_emit_spike.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_neuroncurrents_@NEURON_NAME@.cpp.jinja2 # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_neuroncurrents_@NEURON_NAME@.h.jinja2 # pynestml/utils/ast_mechanism_information_collector.py # pynestml/utils/mechs_info_enricher.py # pynestml/utils/recs_info_enricher.py # pynestml/utils/syns_info_enricher.py # tests/nest_compartmental_tests/test__compartmental_stdp.py
clinssen
reviewed
Jul 28, 2026
…_merge_prepare' into origin/LeanderEwert_cm_optimized_merge_prepare
clinssen
reviewed
Jul 28, 2026
clinssen
reviewed
Jul 28, 2026
clinssen
reviewed
Jul 28, 2026
clinssen
reviewed
Jul 28, 2026
clinssen
reviewed
Jul 28, 2026
clinssen
reviewed
Jul 28, 2026
| __attribute__( ( always_inline ) ) inline float | ||
| cm_fast_propagator_exp( const float x ) | ||
| { | ||
| // Degree-5 polynomial approximation of exp(x) on [-2, 0]. |
Contributor
There was a problem hiding this comment.
Is there any attribution/citation available for this code?
clinssen
reviewed
Jul 28, 2026
…o difference in results compared to nest standard models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various optimisations for the compartmental feature, including:
This PR should be used for merging going forward. We kindly ask that PR #1319 not be touched until this one is merged, as it is referenced by paper code under review!