Implement support for new JMdictDB <example> element#47
Open
machinamentum wants to merge 5 commits into
Open
Conversation
Author
|
This maybe closes #18 even though this change does not parse and store the examples directly from tatoeba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime in 2021, the JMdictDB project added back in examples in a new format.
DTD reference: https://gitlab.com/yamagoya/jmdictdb/-/blob/master/jmdictdb/data/dtd-jmdict.xml
There are ~30k example sentence pairs (described as "priority", whatever that means) imported from tatoeba.
Using these sentences requires rebuilding the jamdict database with JMdict_e_examp.gz found at https://web.archive.org/web/20250401012724/https://www.edrdg.org/wiki/index.php/Main_Page in place of JMdict_e.gz. As of writing this, JMdict_e_examp.gz from archive.org has creation date of 28 March 2025.
It looks like it is also relatively straightforward to generate the latest JMdict_e and JMdict_e_examp XML files using the tooling from the JMdictDB project, see https://gitlab.com/yamagoya/jmdictdb/-/blob/master/doc/OPERATION.txt
This change adds:
<example>elementExample output from lookup.py: