Fix rollback exception propagating#1737
Closed
nsauk wants to merge 3 commits into
Closed
Conversation
nsauk
marked this pull request as draft
March 18, 2026 20:41
nsauk
marked this pull request as ready for review
March 18, 2026 20:52
nsauk
commented
Mar 19, 2026
Comment on lines
+135
to
+137
| errors = ActiveGraph::Base.transaction do | ||
| student.update(name: nil) | ||
| student.errors.full_messages |
Contributor
Author
There was a problem hiding this comment.
This may look unnatural, but graphiti performs validations inside the transaction.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in
Transaction#rollback#1736 lead to the issue with a dependent app's ability to handle failed validation, resulting in HTTP 200 in places where HTTP 422 was before. This PR restores the behavior.