Skip to content

Update the cypher test setup in Database administration and Authentication and Authorization sections - #3206

Open
renetapopova wants to merge 17 commits into
neo4j:devfrom
renetapopova:dev-update-list-of-roles
Open

Update the cypher test setup in Database administration and Authentication and Authorization sections#3206
renetapopova wants to merge 17 commits into
neo4j:devfrom
renetapopova:dev-update-list-of-roles

Conversation

@renetapopova

Copy link
Copy Markdown
Collaborator

…ation and Authorization sections

@renetapopova
renetapopova requested a review from Hunterness July 23, 2026 13:44
@renetapopova renetapopova changed the title Update the cypher test setup in Database administration and Authentic… Update the cypher test setup in Database administration and Authentication and Authorization sections Jul 23, 2026
@Hunterness Hunterness added the team-cypher-operations Cypher operations should review this label Jul 23, 2026

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 7 files left to look at but pausing for lunch so I'm posting the comments I have so far

Comment thread modules/ROOT/pages/authentication-authorization/manage-execute-permissions.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-privileges.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-privileges.adoc Outdated

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of remaining files

Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
@Hunterness Hunterness self-assigned this Jul 28, 2026

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of updates

Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm leaving on vacation now and won't be able to continue reviewing this (I'll make sure someone else from the team picks it up).

The only things I don't really agree with are the manage-users setup: the show examples assume one user that is added in the create examples (after the show) and not the ones you added in the setup. Additionally, one of the setup users should not be there at all as the one from create is renamed to that name and the second one (alice) can probably just not exist as per the comment where she is used 🤷 There are also some setup that might be needed for later sections that the earlier ones don't consider so having it as the page setup feels odd but it might still be good to add for those sections 🤷

And then there is my two comments on the manage-privileges page that I guess we'll open a new PR to fix later as they don't have to do with the setup but are still wrong.

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the users and role pages, still have to look at the privilege page but I'm breaking for the day so here are the comments I have so far

Status: 3 open comments

Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-roles.adoc Outdated

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that many comments on the privilege file at least 🎉

Comment thread modules/ROOT/pages/authentication-authorization/manage-privileges.adoc Outdated
@@ -1244,7 +1219,7 @@ SET STATUS ACTIVE;
The equivalent command using the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax would be:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The equivalent command using the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax would be:
Alternatively, you can use the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax, for example:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update seems to have been lost as I don't see it when looking at all changes, the sentence still says "equivalent command"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the user is the same - jake

@renetapopova
renetapopova force-pushed the dev-update-list-of-roles branch from 757f242 to 4214977 Compare August 20, 2026 18:14

@Hunterness Hunterness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review, some new comments and some old ones re-opened as they had not been fixed

Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
| "joe" | ["PUBLIC"] | TRUE | TRUE | "anotherdb" | "native" | {changeRequired: TRUE, password: "***"} |
| "molly" | ["PUBLIC"] | FALSE | FALSE | NULL | "native" | {changeRequired: FALSE, password: "***"} |
| "neo4j" | ["admin", "PUBLIC"] | FALSE | FALSE | NULL | "native" | {changeRequired: FALSE, password: "***"} |
+----------------------------------------------------------------------------------------------------------------------------------------+

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't have to do with auth rules? it has to do with native vs external auth for the users?

and it might be nice for this example if we add in another user with multiple auths to show the behaviour

CREATE USER sandra 
SET AUTH 'native' {SET PASSWORD 'abcd1234' SET PASSWORD CHANGE NOT REQUIRED}
SET AUTH 'oidc1' {SET ID 'sandrasUniqueMySsoId'};

Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc
@@ -1244,7 +1219,7 @@ SET STATUS ACTIVE;
The equivalent command using the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax would be:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update seems to have been lost as I don't see it when looking at all changes, the sentence still says "equivalent command"

[SET TAG[S] tags] # <4>
----
Where:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list below need to be updated to reflect the tags update:

the <2> needs updating for syntax:

<2> Removes one, several, or all existing tags from each listed user.
Use `REMOVE TAG[S] tag` to remove specific tags, or `REMOVE ALL TAG[S]` to remove every tag.

and then we should add the

Specific tags must be supplied as a single quoted `STRING` value, a `LIST` containing `STRING` values, or a parameter resolving to a `STRING` or a `LIST<STRING>`.

sentence to the general paragraph below that talks about where the tags are used from

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about removing tags, not adding them. Why do you want to add the sentence here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware #3245, so we don't get weird ordering or examples out of sync as you are both changing things here (and in the roles file)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment on that one as well: #3245 (comment)

Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Comment thread modules/ROOT/pages/authentication-authorization/manage-users.adoc Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-this-to-main team-cypher-operations Cypher operations should review this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants