Update the cypher test setup in Database administration and Authentication and Authorization sections - #3206
Update the cypher test setup in Database administration and Authentication and Authorization sections#3206renetapopova wants to merge 17 commits into
Conversation
Hunterness
left a comment
There was a problem hiding this comment.
So I'm leaving on vacation now and won't be able to continue reviewing this (I'll make sure someone else from the team picks it up).
The only things I don't really agree with are the manage-users setup: the show examples assume one user that is added in the create examples (after the show) and not the ones you added in the setup. Additionally, one of the setup users should not be there at all as the one from create is renamed to that name and the second one (alice) can probably just not exist as per the comment where she is used 🤷 There are also some setup that might be needed for later sections that the earlier ones don't consider so having it as the page setup feels odd but it might still be good to add for those sections 🤷
And then there is my two comments on the manage-privileges page that I guess we'll open a new PR to fix later as they don't have to do with the setup but are still wrong.
Hunterness
left a comment
There was a problem hiding this comment.
Not that many comments on the privilege file at least 🎉
| @@ -1244,7 +1219,7 @@ SET STATUS ACTIVE; | |||
| The equivalent command using the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax would be: | |||
There was a problem hiding this comment.
| The equivalent command using the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax would be: | |
| Alternatively, you can use the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax, for example: |
There was a problem hiding this comment.
this update seems to have been lost as I don't see it when looking at all changes, the sentence still says "equivalent command"
There was a problem hiding this comment.
because the user is the same - jake
…ation and Authorization sections
757f242 to
4214977
Compare
Hunterness
left a comment
There was a problem hiding this comment.
Re-review, some new comments and some old ones re-opened as they had not been fixed
| | "joe" | ["PUBLIC"] | TRUE | TRUE | "anotherdb" | "native" | {changeRequired: TRUE, password: "***"} | | ||
| | "molly" | ["PUBLIC"] | FALSE | FALSE | NULL | "native" | {changeRequired: FALSE, password: "***"} | | ||
| | "neo4j" | ["admin", "PUBLIC"] | FALSE | FALSE | NULL | "native" | {changeRequired: FALSE, password: "***"} | | ||
| +----------------------------------------------------------------------------------------------------------------------------------------+ |
There was a problem hiding this comment.
this doesn't have to do with auth rules? it has to do with native vs external auth for the users?
and it might be nice for this example if we add in another user with multiple auths to show the behaviour
CREATE USER sandra
SET AUTH 'native' {SET PASSWORD 'abcd1234' SET PASSWORD CHANGE NOT REQUIRED}
SET AUTH 'oidc1' {SET ID 'sandrasUniqueMySsoId'};
| @@ -1244,7 +1219,7 @@ SET STATUS ACTIVE; | |||
| The equivalent command using the xref:authentication-authorization/auth-providers.adoc[auth providers] syntax would be: | |||
There was a problem hiding this comment.
this update seems to have been lost as I don't see it when looking at all changes, the sentence still says "equivalent command"
| [SET TAG[S] tags] # <4> | ||
| ---- | ||
| Where: | ||
|
|
There was a problem hiding this comment.
the list below need to be updated to reflect the tags update:
the <2> needs updating for syntax:
<2> Removes one, several, or all existing tags from each listed user.
Use `REMOVE TAG[S] tag` to remove specific tags, or `REMOVE ALL TAG[S]` to remove every tag.
and then we should add the
Specific tags must be supplied as a single quoted `STRING` value, a `LIST` containing `STRING` values, or a parameter resolving to a `STRING` or a `LIST<STRING>`.
sentence to the general paragraph below that talks about where the tags are used from
There was a problem hiding this comment.
This is about removing tags, not adding them. Why do you want to add the sentence here?
There was a problem hiding this comment.
Beware #3245, so we don't get weird ordering or examples out of sync as you are both changing things here (and in the roles file)
There was a problem hiding this comment.
I added a comment on that one as well: #3245 (comment)
Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
|
This PR includes documentation updates Updated pages: |
…ation and Authorization sections