flow/fdb/bpf: fix stale flows on FDB port migration - #14
Open
danpawlik wants to merge 1 commit into
Open
Conversation
When a client moves between bridge ports, stale pending_flows entries can leave TC offload filters pointing at the old interface. Commit 95125f0 ("flow: reject pending flows with mismatched fdb device") skipped mismatched pending flows instead of migrating the FDB, which avoids refresh errors but never clears the stale filters. Additionally, pending_flows are processed in hash order, so a stale entry processed after fdb_set_device() can trigger backwards migration on the same poll cycle and re-install filters for the departed port. This commonly shows up during WiFi band roaming (e.g. 2.4 GHz to 5 GHz on dual-band APs), but applies to any FDB port migration on a bridged interface. - flow.c: migrate FDB when pending flow arrives on a different port - bpf.c: flush pending_flows for an interface - fdb.c: flush stale pending flows on migration; defer FDB deletion - nl.c: schedule deferred FDB delete on neighbor removal Signed-off-by: Daniel Pawlik <pawlik.dan@gmail.com>
Author
|
@nbd168 hey, if the PR is useless, just close it. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client moves between bridge ports, stale pending_flows entries can leave TC offload filters pointing at the old interface. Commit 95125f0 ("flow: reject pending flows with mismatched fdb device") skipped mismatched pending flows instead of migrating the FDB, which avoids refresh errors but never clears the stale filters.
Additionally, pending_flows are processed in hash order, so a stale entry processed after fdb_set_device() can trigger backwards migration on the same poll cycle and re-install filters for the departed port.
This commonly shows up during WiFi band roaming (e.g. 2.4 GHz to 5 GHz on dual-band APs), but applies to any FDB port migration on a bridged interface.