Skip to content

Fix nasa#499, shmat() in cfe_psp_memory.c uses NULL instead of zero. - #500

Open
myc-yang wants to merge 1 commit into
nasa:devfrom
myc-yang:499-shmat-use-zero-instead-null
Open

myc-yang wants to merge 1 commit into
nasa:devfrom
myc-yang:499-shmat-use-zero-instead-null

Conversation

@myc-yang

@myc-yang myc-yang commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Describe the contribution
Fixes #499

Expected behavior changes
No Impact on Behavior

Testing performed
GitHub Actions and Axle

Expected behavior changes
Resolve Axle warnings on uninitialized variables

System(s) tested on
GitHub Actions and Axle.

Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang / NASA GSFC

For members of the cFS Team
Click the Preview tab and select the pull request template corresponding to the type of change you are submitting:

@jphickey jphickey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be pedantic -- this should also remove the (void*) cast.

NULL is already a pointer-type value. It should not be cast as such.

@myc-yang
myc-yang force-pushed the 499-shmat-use-zero-instead-null branch from 6004967 to 687f7b9 Compare August 27, 2026 20:08
@myc-yang

Copy link
Copy Markdown
Contributor Author

@jphickey - Thanks, I made the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calls to shmat() in cfe_psp_memory.c uses zero instead of NULL pointer

3 participants