Skip to content

Fix #153, Adjust LC Files to Work with EDS Generated COSMOS Packet Definition Files - #154

Open
Cameron-Sykes wants to merge 4 commits into
nasa:devfrom
Cameron-Sykes:fix-153-adjust-for-cosmos-eds
Open

Cameron-Sykes wants to merge 4 commits into
nasa:devfrom
Cameron-Sykes:fix-153-adjust-for-cosmos-eds

Conversation

@Cameron-Sykes

@Cameron-Sykes Cameron-Sykes commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

name: FSW Code Change
about: Flight Software code changes
labels: fsw

Description of Change

  • Command payloads were moved to the msgdefs.h file
  • Command counter names were standardized
  • All payloads that have common uses were combined into 1

Linked Issue

Closes #153

Requirements Impact

  • Requirement ID(s):
  • Requirements updated as necessary
  • Existing requirements are still satisfied by this change

Testing Evidence

Unit Tests (UT Assert)

image

COSMOS Test Suite

Areas of Expertise Touched

  • ASTRO
  • CI/CD
  • COSMOS
  • Cybersecurity
  • Docker
  • EDS
  • Git
  • PSPs
  • SBN
  • SMP
  • Tables
  • TSN
  • Unit Tests
  • Other

Author Checklist

  • Linked GitHub issue is referenced above
  • Code has been formatted with .clang-format
  • Static analysis workflows ran and passed
  • Unit tests (UT Assert) updated/added to cover code changes
  • Unit test workflows ran and passed
  • COSMOS test suite was run; tests updated/added if relevant changes were made
  • Requirements have been reviewed; updated or confirmed still satisfied (see above)
  • Testing evidence is included above
  • Self-review of the diff completed

Reviewer Checklist

  • Code logic is correct and matches the stated intent
  • Code is readable, maintainable, and follows project conventions (ask your lead if you are unsure of where to find these conventions)
  • .clang-format has been applied
  • Static analysis results reviewed and acceptable
  • The change has been exercised by the unit tests (not just that tests pass — the new/changed code paths are actually covered)
  • COSMOS test suite was executed against this change and results reviewed (or confirmed N/A with justification)
  • Reviewer has independently verified the change behaves as described (e.g., by running the tests locally, reviewing CI output in detail, or performing additional ad-hoc testing as warranted)
  • Memory safety reviewed (allocation, bounds, lifetime, stack usage)
  • Requirements impact reviewed and appropriate
  • Error handling is appropriate
  • Appropriate Expert areas have been reviewed

Reviewer Testing Notes

@Cameron-Sykes Cameron-Sykes self-assigned this Oct 28, 2026
@Cameron-Sykes
Cameron-Sykes force-pushed the fix-153-adjust-for-cosmos-eds branch from c83922e to 8b0cbf9 Compare October 28, 2026 15:09
@Cameron-Sykes
Cameron-Sykes force-pushed the fix-153-adjust-for-cosmos-eds branch from 8b0cbf9 to 337886d Compare October 28, 2026 15:25
@Cameron-Sykes
Cameron-Sykes force-pushed the fix-153-adjust-for-cosmos-eds branch from 337886d to 9b4ded7 Compare October 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust LC Files to Work with EDS Generated COSMOS Packet Definition Files

1 participant