Repository navigation
Fix #98, remove unused HK table type aliases - #100
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Author
|
Could someone review the unused table-type cleanup when time allows? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Contribution
Fixes #98.
Remove the three unused aliases identified in the report:
HK_RuntimeTable_Array_t,hk_copy_table_entry_t, andhk_runtime_tbl_entry_t. Repository-wide exact-name searches found each only at its declaration before the change and no remaining references afterward.Retain the canonical
HK_CopyTableEntry_tandHK_RuntimeTableEntry_tstructures, the actively usedHK_CopyTable_Array_t, and the publichk_tbl.hinclude wrapper. No table entry fields, command/telemetry structures, or runtime logic change.Compatibility
This intentionally retires two legacy compatibility aliases and one unused array alias. Downstream table sources still using
hk_copy_table_entry_torhk_runtime_tbl_entry_tmust useHK_CopyTableEntry_torHK_RuntimeTableEntry_t, respectively. A downstreamHK_RuntimeTable_Array_tdeclaration can useHK_RuntimeTableEntry_t[HK_COPY_TABLE_ENTRIES]. No such downstream usage is assumed to have been audited beyond this repository.Testing performed
Built the HK application module and all four HK unit-test executables against unchanged
devand again with the patch. All four passed both times. The six MD test executables in the same test mission also passed on both runs: 10/10 total.cmake -S cfe -B build-rotationh -DMISSIONCONFIG=rotationh \ -DSIMULATION=native -DENABLE_UNIT_TESTS=ON cmake --build build-rotationh --parallel 4 cmake --build build-rotationh/native/default --parallel 4 --target hk \ coverage-hk-hk_app-testrunner coverage-hk-hk_cmds-testrunner \ coverage-hk-hk_utils-testrunner coverage-hk-hk_dispatch-testrunner ctest --test-dir build-rotationh/native/default --output-on-failure \ --no-tests=error -R '^coverage-hk-'git diff --checkpassed. This declaration-only cleanup introduces no new executable behavior; the existing compiled application tests provide regression coverage. HK baseline:0dc16b7a7bab71747b9c063cf405ad59a65a40a5.System tested
Debian 12 ARM64 in Docker on an Apple Silicon Mac, GCC 12.2.0, CMake 3.31.6. The isolated test mission enables HK and MD, unit tests, and the standard non-EDS interfaces. Its configuration and build outputs are outside this PR.
5dd74afa85e5ed5e8c1ed4129281d21611f8d6995befd8e9f6c62b44bb7ff4c15db8629c0e00efa036c24cb953b047ab5525240579aeb06adf5ac11fThe complete cFS runtime, flight hardware, EDS configuration, and table-file generation were not exercised. The original MISRA analysis tool was not run, and this is not a claim of full MISRA compliance. No third-party code, dependency, or workflow changes.
Contributor
Sylvester Kaczmarek, Personal.