242. Valid Anagram - #65
Open
naoto-iwase wants to merge 2 commits into
Open
Conversation
eito2002
reviewed
Nov 27, 2025
Comment on lines
+324
to
+340
| class Solution: | ||
| def isAnagram(self, s: str, t: str) -> bool: | ||
| if len(s) != len(t): | ||
| return False | ||
|
|
||
| s_char_to_count = {} | ||
| for ch in s: | ||
| if ch not in s_char_to_count: | ||
| s_char_to_count[ch] = 0 | ||
| s_char_to_count[ch] += 1 | ||
|
|
||
| remaining_count = s_char_to_count | ||
| for ch in t: | ||
| if remaining_count.get(ch, 0) == 0: | ||
| return False | ||
| remaining_count[ch] -= 1 | ||
| return True |
There was a problem hiding this comment.
remaining_countとs_char_to_countは同じオブジェクトを指しているので、remaining_countは無くても良いかなと思いました
Owner
Author
There was a problem hiding this comment.
ありがとうございます。
s_char_to_countがtのカウントにより減少していくのは不自然かなと思いつつ、わざわざ複製するほどでもないので同じオブジェクト参照のエイリアス変数を定義しましたが、確かに中途半端でかえって分かりにくい気がします。
おっしゃるとおりremaining_countなしの方が良いですね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
242. Valid Anagram
Next: 235. Lowest Common Ancestor of a Binary Search Tree