Create 0046-permutations.md - #51
Open
naoto-iwase wants to merge 1 commit into
Open
Conversation
shintaro1993
reviewed
Nov 3, 2025
|
|
||
| while stack: | ||
| path = stack.pop() | ||
| if len(path) == len(nums): |
There was a problem hiding this comment.
リストの長さの比較では微妙かもしれませんが、もし nums の代替として set_nums を用意したのであればループの中では len(set_nums) とするのもいいかもしれないと思いました。もしくは set_nums が何に使われる変数なのか(remaining などのように)が名前からもう少しわかるとうれしいなと思いました。
tokuhirat
reviewed
Nov 3, 2025
| class Solution: | ||
| def permute(self, nums: list[int]) -> list[list[int]]: | ||
| all_patterns = [] | ||
| path = [] |
There was a problem hiding this comment.
path や traverse_remainings は操作の形式からつけている名前で、操作の意味からつけると premutation_prefix や build_permutation のような感じになると思いました。形式から変数名をつける場合はコメントでやろうとしていることを書いた方が意味と対応させやすく読みやすいように思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この問題:https://leetcode.com/problems/permutations/
次の問題:https://leetcode.com/problems/subsets/