Skip to content

feat: 10 test-suite improvements — consolidate extended messages, split C headers, add summary matrices, generator validation docs#316

Merged
rijesha merged 3 commits intodevelopfrom
copilot/review-and-optimize-test-files
May 8, 2026
Merged

feat: 10 test-suite improvements — consolidate extended messages, split C headers, add summary matrices, generator validation docs#316
rijesha merged 3 commits intodevelopfrom
copilot/review-and-optimize-test-files

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

  • Investigate CI failures (3 distinct failures)
  • Fix 1: Restore tests/proto/common_types.sf (deleted in prev commit, imported by pkg_test_messages.sf) — fixes Python pkg_test_messages ImportError and TypeScript roundtrip compilation failure
  • Fix 2: Add normalize-expected round-trip in tests/py/include/extended_messages.py::check_message — fixes Python extended decode 0/10 for ProfileBulk and ProfileNetwork

Copilot AI and others added 2 commits May 8, 2026 03:00
…d rust to lang_display, remove failure cap

Agent-Logs-Url: https://github.com/mylonics/struct-frame/sessions/6f5aaf2b-5c1c-4a18-af4a-30259929ea0a

Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
…ts, refresh test-coverage.md; update README

Agent-Logs-Url: https://github.com/mylonics/struct-frame/sessions/6f5aaf2b-5c1c-4a18-af4a-30259929ea0a

Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
@rijesha
Copy link
Copy Markdown
Contributor

rijesha commented May 8, 2026

@copilot fix the failing test suite

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 8, 2026

@copilot fix the failing test suite

Fixed in commit 17a590b. Two root causes:

  1. common_types.sf accidentally deletedtests/proto/pkg_test_messages.sf imports it; without it the generator couldn't emit get_message_info into pkg_test_messages.py, causing the Python roundtrip ImportError, and the missing common-types.structframe.ts caused the TypeScript roundtrip compilation failure. Restored the file.

  2. check_message missing normalization in tests/py/include/extended_messages.py — fixed-size string fields (e.g. short_text [size=16]) get null-padded during serialisation but the raw constructor value is shorter, so decoded != expected without normalising. Added the same expected_normalized = msg_class.deserialize(expected.serialize()) round-trip that the standard and variable-flag helpers already use, fixing the Python extended decode 0/10 failure for ProfileBulk and ProfileNetwork.

Copilot AI requested a review from rijesha May 8, 2026 03:38
Copilot finished work on behalf of rijesha May 8, 2026 03:38
@rijesha rijesha marked this pull request as ready for review May 8, 2026 04:00
@rijesha rijesha merged commit c76df5b into develop May 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants