Refactor: Remove unreachable code in ChannelSftp._put() method#1077
Open
iyrinnn wants to merge 2 commits into
Open
Refactor: Remove unreachable code in ChannelSftp._put() method#1077iyrinnn wants to merge 2 commits into
iyrinnn wants to merge 2 commits into
Conversation
iyrinnn
commented
Jul 3, 2026
iyrinnn
commented
- Removed hardcoded 'dontcopy = true' variable that made conditional branches unreachable
- Eliminated dead code blocks (lines 569-571, 583-589, 633-641)
- Inlined the only-executed logic for better clarity
- No functional changes, only removed dead code paths
- Build verified: mvn clean compile passes successfully
- Removed hardcoded 'dontcopy = true' variable that made conditional branches unreachable - Eliminated dead code blocks (lines 569-571, 583-589, 633-641) - Inlined the only-executed logic for better clarity - No functional changes, only removed dead code paths - Build verified: mvn clean compile passes successfully
There was a problem hiding this comment.
Pull request overview
This PR refactors ChannelSftp._put(InputStream, ...) by removing a hardcoded flag and the associated unreachable branches, leaving only the actually executed “no-copy” write path to improve readability without changing behavior.
Changes:
- Removed the always-true
dontcopyflag and deleted the unreachable!dontcopybranches. - Inlined the effective buffer setup (
data = obuf.buffer,_s,_datalen) for the remaining execution path. - Simplified the
sendWRITE(...)callsite to the only reachable variant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.