Skip to content

fix(kernel): stop asserting the user's OS in advisor startup context - #770

Merged
mvschwarz merged 1 commit into
mvschwarz:mainfrom
adampog:linux/kernel-platform-neutral
Oct 5, 2026
Merged

mvschwarz merged 1 commit into
mvschwarz:mainfrom
adampog:linux/kernel-platform-neutral

Conversation

@adampog

@adampog adampog commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What a user gets

Before: the kernel advisor's startup context stated "The user is on macOS", so on Linux hosts the advisor began with a wrong picture of the machine. After: it says OpenRig runs on macOS and Linux, and to check the host when it matters.

How you verified it

On b5a9deaf (current main) plus this commit: a 4-line wording change in packages/daemon/specs/rigs/launch/kernel/agents/advisor/lead/startup/context.md. npm run lint passed. There's no automated test for this text. On a Linux host, the advisor seat opened by flagging the macOS assumption as wrong, which is what prompted the change.

Not run: the full npm test and npm run test:ui.

Anything you were unsure about

Whether you'd prefer the kernel to detect the OS and state it, rather than staying platform-neutral. I kept it neutral as the smaller change.

  • One concern per PR; no version bump; no CHANGELOG.md edit
  • Tests added or updated where the change is testable
  • I listed the checks I ran, their results, and any checks I could not run

Made with an agent team (Claude Code and Codex), with an independent QA pass before submission.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that OpenRig runs on macOS and Linux, and that the host operating system should be checked when relevant.

The kernel advisor's startup notes said "The user is on macOS", so on
Linux hosts it opened with a wrong picture of the machine. Say OpenRig
runs on macOS and Linux, and to check the host when it matters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 99e0156)
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 96763d35-1c26-42e0-a74d-effb8793cb0d
📥 Commits

Reviewing files that changed from the base of the PR and between b5a9dea and af0e03c.

📒 Files selected for processing (1)
  • packages/daemon/specs/rigs/launch/kernel/agents/advisor/lead/startup/context.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The startup context now states that OpenRig runs on macOS and Linux. It no longer assumes a specific host OS and advises checking the host OS when relevant. The Claude Code and/or Codex authentication assumption remains.

Changes

Startup context

Layer / File(s) Summary
Update host OS guidance
packages/daemon/specs/rigs/launch/kernel/agents/advisor/lead/startup/context.md
The context names macOS and Linux support, leaves the host OS unspecified, and advises checking it when relevant. It retains the Claude Code and/or Codex authentication assumption.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to af0e0

The startup context no longer assumes a macOS host and reflects the documented macOS and Linux support. No material merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to af0e0

The change affects 1 system.

Changed systems: packages/daemon

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/daemon (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/daemon/specs/rigs/launch/kernel/agents/advisor/lead/startup/context.md: The context retains the assumption that the user has Claude Code and/or Codex authenticated, but replaces the macOS-only assumption with macOS and Linux support and guidance to check the host OS when it matters.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the macOS assumption from the advisor startup context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mvschwarz

Copy link
Copy Markdown
Owner

Thanks, @adampog. On current main, the kernel advisor's startup context does say "The user is on macOS". We've approved the CI runs, and it's with the team for review. Your question about detecting the OS rather than staying neutral is part of that review.

@openrig-review openrig-review left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at af0e03c. Text only: the kernel advisor's startup context no longer tells the agent the user is on macOS. It now says OpenRig runs on macOS and Linux and to check (for example uname -s) when it matters. That's better than having the kernel detect the OS: the agent can check at the moment it needs to. All 8 required checks pass. Thank you.

— dev60-planner@v-openrig-build

@mvschwarz
mvschwarz merged commit 4f3952e into mvschwarz:main Oct 5, 2026
10 checks passed
@mvschwarz

Copy link
Copy Markdown
Owner

Merged, thanks @adampog. The kernel advisor no longer assumes macOS, and checks the host when it matters. On your question, we kept it neutral as you wrote it rather than detecting and stating the OS. It's on main and isn't in a release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants