fix(kernel): stop asserting the user's OS in advisor startup context - #770
Conversation
The kernel advisor's startup notes said "The user is on macOS", so on Linux hosts it opened with a wrong picture of the machine. Say OpenRig runs on macOS and Linux, and to check the host when it matters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 99e0156)
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe startup context now states that OpenRig runs on macOS and Linux. It no longer assumes a specific host OS and advises checking the host OS when relevant. The Claude Code and/or Codex authentication assumption remains. ChangesStartup context
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The startup context no longer assumes a macOS host and reflects the documented macOS and Linux support. No material merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks, @adampog. On current main, the kernel advisor's startup context does say "The user is on macOS". We've approved the CI runs, and it's with the team for review. Your question about detecting the OS rather than staying neutral is part of that review. |
openrig-review
left a comment
There was a problem hiding this comment.
Approved at af0e03c. Text only: the kernel advisor's startup context no longer tells the agent the user is on macOS. It now says OpenRig runs on macOS and Linux and to check (for example uname -s) when it matters. That's better than having the kernel detect the OS: the agent can check at the moment it needs to. All 8 required checks pass. Thank you.
— dev60-planner@v-openrig-build
|
Merged, thanks @adampog. The kernel advisor no longer assumes macOS, and checks the host when it matters. On your question, we kept it neutral as you wrote it rather than detecting and stating the OS. It's on main and isn't in a release yet. |
What a user gets
Before: the kernel advisor's startup context stated "The user is on macOS", so on Linux hosts the advisor began with a wrong picture of the machine. After: it says OpenRig runs on macOS and Linux, and to check the host when it matters.
How you verified it
On
b5a9deaf(currentmain) plus this commit: a 4-line wording change inpackages/daemon/specs/rigs/launch/kernel/agents/advisor/lead/startup/context.md.npm run lintpassed. There's no automated test for this text. On a Linux host, the advisor seat opened by flagging the macOS assumption as wrong, which is what prompted the change.Not run: the full
npm testandnpm run test:ui.Anything you were unsure about
Whether you'd prefer the kernel to detect the OS and state it, rather than staying platform-neutral. I kept it neutral as the smaller change.
CHANGELOG.mdeditMade with an agent team (Claude Code and Codex), with an independent QA pass before submission.
🤖 Generated with Claude Code
Summary by CodeRabbit