Skip to content

test: retain issue 728 reporter picker captures - #765

Merged
mvschwarz merged 1 commit into
mainfrom
test/issue728-reporter-picker
Oct 5, 2026
Merged

mvschwarz merged 1 commit into
mainfrom
test/issue728-reporter-picker

Conversation

@mvschwarz

@mvschwarz mvschwarz commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Adds the #728 reporter’s Claude Code 2.1.289 macOS picker excerpt and their explicitly constructed wrapped-description variant beside the existing question-picker fixtures. Both must remain attention / selection_prompt, with the selected option 12 and 13 nonblank lines from the bottom respectively.

The excerpts preserve the published text from @gopinathrimc. Tests retain the stated position in a 160×50 pane using disclosed blank padding for the unprovided header; the inserted line is not presented as a native capture. Test-only change; no classifier behavior changes.

Validation: both inputs passed a bounded check of the unchanged main classifier. Full test-file and suite validation runs in CI.

Refs #728.

Summary by CodeRabbit

  • Tests
    • Added coverage for detecting Claude Code selection prompts when they appear at different positions in a terminal pane, including excerpts with wrapped descriptions.
    • Added a recorded terminal-screen example to support these checks.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a0a0cd6a-2b9e-47db-ba9f-6055e3149f63
📥 Commits

Reviewing files that changed from the base of the PR and between 2cc9de9 and c9b4be3.

📒 Files selected for processing (2)
  • packages/daemon/test/claude-question-picker.test.ts
  • packages/daemon/test/fixtures/claude-question-picker-issue728.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The change adds a Claude question-picker capture fixture and a parameterized test. The test checks selection distance and attention-state classification for the captured excerpt and a wrapped-description variant.

Changes

Question picker regression coverage

Layer / File(s) Summary
Fixture and regression test
packages/daemon/test/fixtures/claude-question-picker-issue728.json, packages/daemon/test/claude-question-picker.test.ts
The fixture records the captured prompt and wrapped-description variant. The parameterized test checks selector distance and expects classifyPaneActivity to identify an attention-state selection prompt.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c9b4b

This test-only change adds coverage for the captured and wrapped picker prompts. No merge-blocking risk is evident from the reviewed context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the test-only change: retaining the issue 728 reporter picker captures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openrig-review openrig-review left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at c9b4be3. Test-only: adds the #728 reporter's Claude Code 2.1.289 macOS question-picker capture (160x50, excerpt at lines 17-33 with blank rows elsewhere) and their one-line constructed wrapped-description variant as fixtures, and asserts both classify as attention / selection_prompt at their original pane positions. Every captured line matches the public comment, the fixture carries its source, and product code is unchanged. All 8 required checks pass.

— dev60-planner@v-openrig-build

@mvschwarz
mvschwarz merged commit b5a9dea into main Oct 5, 2026
10 checks passed
@mvschwarz
mvschwarz deleted the test/issue728-reporter-picker branch October 5, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants