Repository navigation
fix(security): hosted sites on pleng_web no longer count as internal - #2
Merged
Merged
Conversation
Every hosted site joins pleng_web, and platform-api treated any private IP without X-Forwarded-For as internal: a site with an SSRF or a compromised container could read /internal/key and use the admin API (compose deploys with the Docker socket). Requests from the pleng_web subnets now need the API key like any external caller; the agent and Telegram bot on the internal network keep the no-auth path. If the subnet can't be read it fails closed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every hosted site joins
pleng_web, and platform-api treated any private IP withoutX-Forwarded-Foras internal. A site with an SSRF or a compromised container could read/internal/keyand use the admin API, which runs compose deploys with the Docker socket.Requests from the
pleng_websubnets now need the API key like any external caller. The agent and Telegram bot on theinternalnetwork keep the no-auth path. If the subnet can't be read, it fails closed.Tests:
platform-api/tests/test_internal_boundary.py(46/46 pass).🤖 Generated with Claude Code