Skip to content

fix(security): hosted sites on pleng_web no longer count as internal - #2

Merged
mutonby merged 1 commit into
mutonby:mainfrom
victorcavero14:fix/internal-boundary
Nov 7, 2026
Merged

mutonby merged 1 commit into
mutonby:mainfrom
victorcavero14:fix/internal-boundary

Conversation

@victorcavero14

Copy link
Copy Markdown
Contributor

Every hosted site joins pleng_web, and platform-api treated any private IP without X-Forwarded-For as internal. A site with an SSRF or a compromised container could read /internal/key and use the admin API, which runs compose deploys with the Docker socket.

Requests from the pleng_web subnets now need the API key like any external caller. The agent and Telegram bot on the internal network keep the no-auth path. If the subnet can't be read, it fails closed.

Tests: platform-api/tests/test_internal_boundary.py (46/46 pass).

🤖 Generated with Claude Code

Every hosted site joins pleng_web, and platform-api treated any private IP
without X-Forwarded-For as internal: a site with an SSRF or a compromised
container could read /internal/key and use the admin API (compose deploys
with the Docker socket). Requests from the pleng_web subnets now need the API
key like any external caller; the agent and Telegram bot on the internal
network keep the no-auth path. If the subnet can't be read it fails closed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mutonby
mutonby merged commit db0aea3 into mutonby:main Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants