Skip to content

migrate remaining scripts from yarn to pnpm - #1736

Merged
radumojic merged 1 commit into
developmentfrom
rm/migrate-yarn-pnpm
Jul 13, 2026
Merged

migrate remaining scripts from yarn to pnpm#1736
radumojic merged 1 commit into
developmentfrom
rm/migrate-yarn-pnpm

Conversation

@radumojic

Copy link
Copy Markdown
Contributor

Issue/Feature

  • migrate remaining scripts from yarn to pnpm

Contains breaking changes

  • No
  • Yes

Updated CHANGELOG

  • No
  • Yes

Testing

  • User testing
  • Unit tests

@radumojic
radumojic merged commit 13e0d31 into development Jul 13, 2026
1 check passed
@radumojic
radumojic deleted the rm/migrate-yarn-pnpm branch July 13, 2026 17:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project from Yarn to pnpm, updating the documentation, changelog, and integration scripts. The review feedback highlights a critical issue in the integration script where pnpm install --no-frozen-lockfile must be executed after yalc add to ensure the local package is correctly symlinked before building.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


echo "Building mx-template-dapp..."
yarn build-devnet
pnpm build-devnet

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

When migrating from Yarn to pnpm, yalc add modifies package.json to point to the local .yalc directory, but pnpm's content-addressable store and symlink structure require a subsequent pnpm install to actually link the package in node_modules. Without running pnpm install after yalc add, the build step will use the registry version of @multiversx/sdk-dapp instead of the locally built one. Since package.json was modified, run pnpm install --no-frozen-lockfile before building.

Suggested change
pnpm build-devnet
pnpm install --no-frozen-lockfile
pnpm build-devnet


echo "Building mx-template-dapp-nextjs..."
yarn build:devnet
pnpm build:devnet

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similarly, for mx-template-dapp-nextjs, pnpm install --no-frozen-lockfile must be run after yalc add to ensure the local package is correctly symlinked in node_modules before building.

Suggested change
pnpm build:devnet
pnpm install --no-frozen-lockfile
pnpm build:devnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant