migrate remaining scripts from yarn to pnpm - #1736
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project from Yarn to pnpm, updating the documentation, changelog, and integration scripts. The review feedback highlights a critical issue in the integration script where pnpm install --no-frozen-lockfile must be executed after yalc add to ensure the local package is correctly symlinked before building.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| echo "Building mx-template-dapp..." | ||
| yarn build-devnet | ||
| pnpm build-devnet |
There was a problem hiding this comment.
When migrating from Yarn to pnpm, yalc add modifies package.json to point to the local .yalc directory, but pnpm's content-addressable store and symlink structure require a subsequent pnpm install to actually link the package in node_modules. Without running pnpm install after yalc add, the build step will use the registry version of @multiversx/sdk-dapp instead of the locally built one. Since package.json was modified, run pnpm install --no-frozen-lockfile before building.
| pnpm build-devnet | |
| pnpm install --no-frozen-lockfile | |
| pnpm build-devnet |
|
|
||
| echo "Building mx-template-dapp-nextjs..." | ||
| yarn build:devnet | ||
| pnpm build:devnet |
There was a problem hiding this comment.
Issue/Feature
Contains breaking changes
Updated CHANGELOG
Testing