Verbose technic_run performance logging - #456
Draft
S-S-X wants to merge 1 commit into
Draft
Conversation
Click for detailed source code test coverage reportTest coverage report for Technic CNC 87.49% in 11/14 files:Test coverage report for technic chests 44.99% in 6/6 files:Test coverage report for technic 70.90% in 96/96 files:Raw test runner output for geeks:CNC: Chests: Technic: |
Contributor
|
You could group each node type together, and possibly include the slowest out of each group. I think the request in the issue was to know the performance of each type of machine, not every individual node. I think reading |
|
Yeah, grouping would be nice. Is it possible/practical to write the performance logging to something, similar to how /profiler print with luanti’s builtin profiler does it(into chat or file)? |
Member
Author
Could do something similar to Grouping has a problem, time required for individual machine execution cycle isn't anywhere near constant but depends heavily on what machine is actually doing during cycle that is used to measure lag. Time required for each individual cycle of each individual machine can vary a lot from almost nothing to something significant and that's what makes grouping hard. This is why this data might not be that useful for mod performance improvements and if all machines would be grouped by type and then only aggregate data used for listing then it would also not be that useful for finding heavy in world factories. Some kind of performance monitoring could be added but important thing is to understand what issues we're trying to solve with collected data. |
|
My original reason for the request was to get an average performance impact caused, similar to luanti builtin profiler. I had wanted to see mainly which machine type caused the most/largest slowdowns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should work and should not affect performance at all unless configuration option is enabled.
Will generate way too much log lines, should probably aggregate somehow:
sma(size)generator).Instead of dedicated config should it be checking Luanti's log level
debug_log_leveland begin logging if set toverboseortrace?