fix: version-gate generated RawProps::at() for react-native 0.87#1424
Open
cortinico wants to merge 1 commit into
Open
fix: version-gate generated RawProps::at() for react-native 0.87#1424cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
react-native 0.87 removed the (name, prefix, suffix) overload of react::RawProps::at() in favor of a single-argument at(name) (D94367880), breaking codegen output on newer react-native while older versions (<= 0.86) still require the 3-argument form. Update the CppHybridViewComponent codegen template to emit a NITRO_RAWPROPS_AT macro guarded by REACT_NATIVE_VERSION_* (from <cxxreact/ReactNativeVersion.h>): * RN > 0.86 (incl. nightly 1000.x): rawProps.at(name) * RN <= 0.86: rawProps.at(name, nullptr, nullptr) Regenerate the committed HybridTestView / HybridRecyclableTestView component files so the generated output stays in sync with the template.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
cortinico
marked this pull request as ready for review
June 26, 2026 12:39
Owner
|
Hey Nico thanks for this PR! Really appreciate it ❤️ There is no super elegant fix for this, but I just created #1425 which ships this in a Btw., this begs the question - why don't we keep a |
Author
Yeah we're re-adding it but we intend to remove it in a future version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native 0.87 removed the (name, prefix, suffix) overload of
react::RawProps::at() in favor of a single-argument at(name):
This breaks nitro codegen output on newer react-native while older versions
(<= 0.86) still require the 3-argument form.
Update the CppHybridViewComponent codegen template to emit a
NITRO_RAWPROPS_AT macro guarded by REACT_NATIVE_VERSION_* (from
<cxxreact/ReactNativeVersion.h>):
Regenerate the committed HybridTestView / HybridRecyclableTestView
component files so the generated output stays in sync with the template.