Repository navigation
Conversation
Owner
|
Is this a real problem you’ve actually encountered, or is it just some contrived, empty nonsense? |
Author
|
This came from generated CAD checks, not a production drawing or a user report. I do not have a real-world DXF affected by it. The example reproduces a partial arc turning into a full ellipse under an identity transform, but the tiny interval was chosen to exercise the tolerance boundary. I have added that origin to the description. |
Owner
|
I don’t want to open the door to these kinds of theoretical problems—come back when you’re dealing with real-world issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transforming a short elliptic arc can turn it into a full ellipse, even with the identity matrix. This changes the geometry subsequently saved to DXF. This was found with generated CAD geometry; I do not have an affected user or production drawing.
Remember the original full-ellipse state before adjusting axes and parameters. Transform distinct short-arc endpoints and restore a full-turn interval only for an originally full ellipse. Equal-endpoint handling stays compatible.
Validation on Python 3.12:
Tiny-arc rendering also encounters a separate angle-span tolerance problem; this change preserves the transformed geometry independently of that correction.