Repository navigation
Add logging-possiblity to send_msg()-functiongroup - #326
Merged
Merged
Conversation
msirringhaus
force-pushed
the
logging_updates
branch
from
January 22, 2024 12:09
0946490 to
a572262
Compare
msirringhaus
force-pushed
the
logging_updates
branch
from
October 28, 2025 12:17
a572262 to
e4d16ff
Compare
micolous
force-pushed
the
logging_updates
branch
from
September 30, 2026 05:17
e4d16ff to
d078e4c
Compare
micolous
approved these changes
Sep 30, 2026
micolous
left a comment
micolous
left a comment
Collaborator
There was a problem hiding this comment.
I rebased this at HEAD, and also made RequestDirection also include the protocol version (CTAP 1 vs. CTAP2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stab at logging-capability.
Requests and Responses are converted to String and then send via StatusUpdates.
I added the status-callback function to all send_msg()-functions, as an Option. Various minor calls like
GetInfoand all PIN-related operations (like establishing shared secrets, etc.) are currently intentionally not logged.