Skip to content

tests: run the ucode syntax check from run_tests.sh - #207

Merged
stangri merged 1 commit into
mossdef-org:1.2.4from
egc112:pbr-1.2.4-tests-syntax-gate-in-runner
Nov 9, 2026
Merged

stangri merged 1 commit into
mossdef-org:1.2.4from
egc112:pbr-1.2.4-tests-syntax-gate-in-runner

Conversation

@egc112

@egc112 egc112 commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

check-ucode-syntax.sh is run only by ucode-syntax.yml, so in a copy of the tree without .github, such as the OpenWrt feed, nothing calls it.

It can't simply be called from run_tests.sh. It is only meaningful on the oldest supported ucode and refuses anything newer, while the suite runs on current ucode. So take that interpreter from PBR_UCODE_OLDEST, and report the check as skipped when it isn't set. ucode-syntax.yml is unchanged and keeps running the script directly.

Add tests/README.md describing what each script is for and where it runs.

Suggested in the review of openwrt/packages#31156. Checked three ways: unset (skipped, no failure), the ucode in OpenWrt 25.12 (passes), and a current ucode (fails on the canary).

Assisted-by: Claude:claude-opus-5-5

check-ucode-syntax.sh is run only by ucode-syntax.yml, so in a copy of the
tree without .github, such as the OpenWrt feed, nothing calls it.

It can't simply be called from run_tests.sh. It is only meaningful on the
oldest supported ucode and refuses anything newer, while the suite runs
on current ucode. So take that interpreter from PBR_UCODE_OLDEST, and
report the check as skipped when it isn't set. ucode-syntax.yml is
unchanged and keeps running the script directly.

Add tests/README.md describing what each script is for and where it runs.

Suggested in the review of openwrt/packages#31156. Checked three ways:
unset (skipped, no failure), the ucode in OpenWrt 25.12 (passes), and a
current ucode (fails on the canary).

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Erik Conijn <egc112@msn.com>
@stangri
stangri merged commit 17067dd into mossdef-org:1.2.4 Nov 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants