Repository navigation
tests: run the ucode syntax check from run_tests.sh - #207
Merged
stangri merged 1 commit intoNov 9, 2026
Merged
Conversation
check-ucode-syntax.sh is run only by ucode-syntax.yml, so in a copy of the tree without .github, such as the OpenWrt feed, nothing calls it. It can't simply be called from run_tests.sh. It is only meaningful on the oldest supported ucode and refuses anything newer, while the suite runs on current ucode. So take that interpreter from PBR_UCODE_OLDEST, and report the check as skipped when it isn't set. ucode-syntax.yml is unchanged and keeps running the script directly. Add tests/README.md describing what each script is for and where it runs. Suggested in the review of openwrt/packages#31156. Checked three ways: unset (skipped, no failure), the ucode in OpenWrt 25.12 (passes), and a current ucode (fails on the canary). Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Erik Conijn <egc112@msn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-ucode-syntax.sh is run only by ucode-syntax.yml, so in a copy of the tree without .github, such as the OpenWrt feed, nothing calls it.
It can't simply be called from run_tests.sh. It is only meaningful on the oldest supported ucode and refuses anything newer, while the suite runs on current ucode. So take that interpreter from PBR_UCODE_OLDEST, and report the check as skipped when it isn't set. ucode-syntax.yml is unchanged and keeps running the script directly.
Add tests/README.md describing what each script is for and where it runs.
Suggested in the review of openwrt/packages#31156. Checked three ways: unset (skipped, no failure), the ucode in OpenWrt 25.12 (passes), and a current ucode (fails on the canary).
Assisted-by: Claude:claude-opus-5-5