Repository navigation
adblock-fast: trigger restart when dnsmasq_instance or smartdns_instance changes - #23
Merged
Merged
Conversation
… smartdns_instance to restart triggers Co-authored-by: stangri <4768176+stangri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support multiple instances on adblock-fast configuration
adblock-fast: trigger restart when dnsmasq_instance or smartdns_instance changes
Aug 10, 2026
stangri
marked this pull request as ready for review
August 10, 2026 19:24
Collaborator
|
@egc I'd appreciate your eyes on this! |
|
I am not sure if I can be of much assistance as I am not very familiar with the adblock-fast source code and have my hands full with another project 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
dns='dnsmasq.conf'(or any dnsmasq/smartdns mode), changingdnsmasq_instanceorsmartdns_instancewhile the service was running would silently do nothing —adb_config_cachefound no matching entry inreloadorrestarttriggers and fell through toskip.Changes
files/lib/adblock-fast/adblock-fast.uc— adddnsmasq_instanceandsmartdns_instancetopkg.triggers.restart:A
restartaction re-runsresolver('update_config'), which iterates all configured instances and setsaddnmount/serversfile/confdir symlinks for each, then restarts the resolver.reload(which triggers a full re-download) is intentionally not used since instance list changes don't require re-fetching blocklists.tests/run_tests.sh— exposepkg.triggersvia_test_internals.pkg_triggers()for use in tests.tests/02_config/03_dnsmasq_conf_instance_triggers— new test assertingdnsmasq_instanceandsmartdns_instanceare inrestarttriggers and absent fromreloadtriggers.