Skip to content

bug fix init ugwp - #44

Open
netosylvio wants to merge 3 commits into
release/2.0.0-rcfrom
feature/bug_fix_init_ugwp
Open

bug fix init ugwp#44
netosylvio wants to merge 3 commits into
release/2.0.0-rcfrom
feature/bug_fix_init_ugwp

Conversation

@netosylvio

Copy link
Copy Markdown
Contributor

Pull Request Description

bug fix init ugwp

(...)

Type of Change

  • Bug fix
  • Hot fix
  • New feature
  • Improvement to existing functionality
  • Code refactoring
  • Code optimization
  • Other: ______

Testing and Quality

  • Code was written following MONAN’s DTN-01 (Coding Standard)
  • Compilation and execution tests of the model were executed
  • Test with the debug flag was executed
  • Results are reproducible with the default configuration

Scientific Impact

Space for further details of the changes made and the improvements introduced. Cite the articles and references used.

(...)

@netosylvio netosylvio changed the title Feature/bug fix init ugwp bug fix init ugwp Jul 28, 2026
@netosylvio
netosylvio requested a review from joaomas July 28, 2026 20:02
@netosylvio

Copy link
Copy Markdown
Contributor Author

updated with a new patch for correction

@netosylvio netosylvio self-assigned this Jul 31, 2026
@netosylvio

Copy link
Copy Markdown
Contributor Author

Bit-for-bit Reproducibility

release/2.0.0-rc (debug_off) vs. feature/bug_fix_init_ugwp (debug_off)

cdo difference = OK
cdo diffv = OK
nccmp = OK
Reproducibility OK
Final result at: Thu, July 30, 2026 23:41:25
Comparison 2026012000 - Model vs. Model
Total identical = 80
Total different = 0


release/2.0.0-rc (debug_off) vs. feature/bug_fix_init_ugwp (debug_off)

image
image
image
image

Statistical Reproducibility

release/2.0.0-rc (debug_off) vs. feature/bug_fix_init_ugwp (debug_ON)

It is accepted in the literature that changes in compilers, optimization, or the order of operations can prevent bit-for-bit reproducibility in atmospheric models. In such cases, numerical or statistical reproducibility is expected, as rounding errors can grow in chaotic systems. [Geyer et al., 2021]

Tests accounted for differences on the order of 1e-2.

Statistical Reproducibility Test
GrADS 2.2.1.oga.1 module loaded
Type 'grads' to start the Grid Analysis and Display System

Test valid for: 2026012000 00Z

==> zonal wind at 100 hPa: OK
==> temperature at 100 hPa: OK
==> specific humidity at 100 hPa: OK
==> geopotential height at 100 hPa: OK
==> rainc: OK
==> lh: OK

Final result: Reproducibility OK


release/2.0.0-rc (debug_off) vs. feature/bug_fix_init_ugwp (debug_ON)

image
image
image
image
image
image

Conclusions

Bit-for-bit reproducibility tests – OK
Comparison test in GrADS – OK
Statistical reproducibility test – OK
Variable and area encroachment test – OK

No anomalies were found in the tests comparing release/2.0.0-rc and feature/bug_fix_init_ugwp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant