Skip to content

fix(tests): EIP-8037 - skip block-gas limit test under monad-runloop - #49

Merged
mijovic merged 1 commit into
forks/monad_ninefrom
fix/runloop-block-gas-limit-skip
Aug 25, 2026
Merged

mijovic merged 1 commit into
forks/monad_ninefrom
fix/runloop-block-gas-limit-skip

Conversation

@pdobacz

@pdobacz pdobacz commented Aug 24, 2026 •

Copy link
Copy Markdown
Collaborator

The runloop builds every block at the proposal gas limit, so the over-limit transaction no longer exceeds it.

Technically, this is a test we will be hard-skipping when working through Amsterdam EIPs, however the conflict with monad runloop test consumption is the second reason to skip this test.

(NOTE the test itself is marked valid from Osaka, which means MONAD_NINE and MONAD_TEN fill this test :()

Greptile Summary

Adds a Monad-runloop-specific skip to a block-gas boundary test whose controlled gas limit is incompatible with the runloop’s fixed proposal gas limit.

  • Preserves the test for normal fixture generation.
  • Skips both parameterized cases only while filling with --monad-runloop.

Confidence Score: 5/5

The PR appears safe to merge because the skip is correctly limited to Monad runloop fixture filling.

The collection hook unwraps this skip only when --monad-runloop is enabled, and the documented and release runloop workflows supply that option.

Important Files Changed

Filename Overview
tests/amsterdam/eip8037_state_creation_gas_cost_increase/test_block_2d_gas_accounting.py Uses the repository’s established conditional-marker pattern to skip the incompatible test only for Monad runloop fixture filling.

Reviews (1): Last reviewed commit: "fix(tests): skip the block-gas inclusion..." | Re-trigger Greptile

The runloop builds every block at the proposal gas limit, so the
over-limit transaction no longer exceeds it.

Co-Authored-By: Claude <claude-opus-5[1m]>
@pdobacz
pdobacz requested review from QEDK and mijovic as code owners August 24, 2026 15:37
@mijovic
mijovic merged commit 59d7ef6 into forks/monad_nine Aug 25, 2026
5 checks passed
@mijovic
mijovic deleted the fix/runloop-block-gas-limit-skip branch August 25, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants