feat(adaptive-points): adaptive-path traversal SDK contracts (epic-029 F4)#12
Merged
Merged
Conversation
Adds the SDK surface for epic-029 feature-004 (design.md §3): IAdaptivePath, IAdaptivePathService, ctx.GetAdaptivePath, and the returned TraverseReport with per-endpoint OffsetState. Contracts only; the host implements the service and handle. Bumps the package to 1.1.0 and references Devices.Robot for Velocity.
DanielKow
commented
Jun 11, 2026
Contributor
Author
Review — Wave 1 (SDK contracts), Epic 029 · Feature 004 Verdict: contracts are clean and conform to design.md §3. No code blockers. One MINOR (csproj version, inline) + one SHOULD release-process caveat (below). ### Design conformance (design.md §3) — ✅ -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the SDK surface for Epic 029 · Feature 004 — Adaptive Path Traversal (design.md §3) to
RocketWelder.SDK.AdaptivePoints, beside the existingIAdaptivePoint/IAdaptivePointService/GetAdaptivePoint. Contracts only — the host implements the service and handle, exactly as it does forIAdaptivePointtoday.Contracts added
IAdaptivePathTraverseAsync(velocity, ct)→TraverseReport. Drives the robot start → mids → end by linear moves; does not adapt.IAdaptivePathServiceGet(startName)/List(). No robot id — mirrorsIAdaptivePointService.ctx.GetAdaptivePath(startName)IProgramContext, twin toGetAdaptivePoint: returns the handle or throws when no path starts at that name.TraverseReportCompleted,StoppedAt(point name a failed/cancelled move stopped on, or null), andStartOffset/EndOffsetasOffsetState.OffsetStateResolved(offset)vsZero— mirrors theAdaptResultdiscriminated-record idiom so the operator reads full / partial / no correction (FR-2.5).Notes
Velocity(fromDevices.Robot) andVector3<double>(fromModelingEvolution.Drawing); added aProjectReferencetoRocketWelder.SDK.Devices.RobotforVelocity.1.0.0→1.1.0(additive). Not published here — publishing is a separate, user-approved step after merge.IAdaptivePoint/AdaptResultexactly. No TODOs, no magic defaults.🤖 Generated with Claude Code