fix: allow integer file descriptors for errlog in stdio_client#2410
Open
RudrenduPaul wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: allow integer file descriptors for errlog in stdio_client#2410RudrenduPaul wants to merge 2 commits intomodelcontextprotocol:mainfrom
RudrenduPaul wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1806
stdio_client()typederrlogasTextIO, preventing callers from passinginteger file descriptors such as
subprocess.DEVNULL. The underlying subprocesscalls (
anyio.open_processandsubprocess.Popen) already accept integers forstderr— this was a type-annotation gap, not a runtime limitation.Motivation and Context
Users running CLI tools or embedding MCP servers in larger applications often
want to suppress server stderr entirely.
subprocess.DEVNULLis the standardPython way to do this, but passing it to
stdio_client()raised a type errorbecause
errlogwas annotated asTextIOonly.How Has This Been Tested?
Type annotation change only — no runtime behaviour changes. The underlying
anyio.open_processandsubprocess.Popencalls already acceptintforstderr. All existing tests continue to pass.Breaking Changes
None. Existing callers using
TextIO(e.g.sys.stderr) are unaffected.Types of changes
Checklist