check server side max streams when proxying - #6
Merged
molocule merged 2 commits intoAug 10, 2026
Merged
Conversation
spawn_stream() admitted streams against the configured max_h2_streams only, snapshotted before the server's initial SETTINGS frame is processed. A server advertising a lower limit (e.g. the worker HTTP relay's per-connection stream cap) caused excess requests to queue silently inside h2 — parked in ready() behind long-lived streams until the downstream deadline killed them — instead of signaling the caller to dial another connection. - Re-read current_max_send_streams() on every admission and admit against min(configured, advertised). - Bound the ready() wait: a connection at its real capacity reports "no free stream" so the caller dials instead of queueing. - Fix a counter leak when spawn_stream() is cancelled mid-wait. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use server side max streams when proxying