Repository navigation
Handle Unicode CSV delimiters - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
With
-d '§',name§surnamecurrently becomes one column.prepareDelimiterreads the first UTF-8 byte, which selects a different character.Decode the first rune so Unicode delimiters split columns correctly. The default comma, ASCII delimiters and hexadecimal inputs keep their behavior.
Added 12 parsing cases for ASCII and Unicode delimiters, quoted fields and empty values. Five fail against current main.
On Go 1.23.4,
go test -v -cover ./...andgo test -race -v -cover ./...pass with 81.8% coverage.go build -v ./...andgo vet ./...also pass. Eight compiled CLI cases pass, including file input with a BOM and file output.