Fix all 12 SME-reviewed issues with TDD coverage - #2
Merged
Conversation
Addresses bugs, reliability gaps, security hardening, and feature requests identified in SME review. All changes driven by strict Red-Green-Refactor TDD discipline (94 tests, up from 67). Bugs: deploy.sh and install_and_start.sh now delegate to install_service.sh instead of raw-copying the service template without placeholder substitution. Reliability: Added desktop alerting via notify-send in health checks, log rotation via RotatingFileHandler (10MB/5 backups), and remote disk space checking before rsync transfers. Security: Re-enabled SystemCallFilter in systemd service, added deprecation notice to bash monitor script. Features: Desktop notifications on sync success/failure, DELETE_AFTER_SYNC config option, multiple watch directory support (comma-separated WATCH_DIR). Code quality: Converted all 33 f-string logging calls to lazy % formatting, removed duplicate imports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy.shandinstall_and_start.shnow delegate toinstall_service.shinstead of raw-copying the service template without placeholder substitutionnotify-sendin health checks, log rotation viaRotatingFileHandler(10MB/5 backups), and remote disk space checking before rsyncSystemCallFilterin systemd service, added deprecation notice to bash monitor scriptDELETE_AFTER_SYNCconfig option, multiple watch directory support (comma-separatedWATCH_DIR)%formatting, removed duplicate importsIssues Addressed
deploy.shoverwrites generated service with raw templateinstall_and_start.shsame raw copy bugmonitor_and_sync.shTest plan
DELETE_AFTER_SYNC=truewith a real .gcode fileWATCH_DIRwith multiple directoriesnotify-sendnotifications appear on sync success/failure🤖 Generated with Claude Code