Skip to content

fix: reject calls without declared tools - #547

Open
TeoSlayer wants to merge 1 commit into
mlcommons:mainfrom
TeoSlayer:fix/empty-tool-list
Open

TeoSlayer wants to merge 1 commit into
mlcommons:mainfrom
TeoSlayer:fix/empty-tool-list

Conversation

@TeoSlayer

@TeoSlayer TeoSlayer commented Oct 28, 2026 •

Copy link
Copy Markdown

Change

Reject tool calls when no tools are declared. Refs #391.

Checks

  • Regression tests added; both new cases fail before the fix.
  • 2,235 unit tests pass; 27 skip.
  • One macOS affinity test fails on both branches.
  • Linux mypy passes. Other hooks pass; macOS mypy flags three existing Linux-only calls.

CI has a base timeout failure. Audit fix: #551. Review requests lack fork permission.

@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions Bot added the size/normal PR Review Policy: <=500 non-test lines & <=20 files label Oct 28, 2026
@TeoSlayer
TeoSlayer marked this pull request as ready for review October 28, 2026 16:12
@TeoSlayer
TeoSlayer requested a review from a team October 28, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/normal PR Review Policy: <=500 non-test lines & <=20 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant