Add Z to fidget::raster::pixel::RenderConfig - #445
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the 2D pixel rasterizer configuration to support rendering a slice at an arbitrary Z value (instead of always evaluating at Z=0), aligning with Issue #444.
Changes:
- Add
z: f32tofidget::raster::pixel::RenderConfigwith a default of0.0. - Thread the configured Z value through interval- and bulk-evaluation paths (
Workerscratch buffers and interval bounds). - Add a unit test validating inside/outside behavior across different Z values, and update the changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fidget-raster/src/pixel.rs | Adds RenderConfig.z, propagates Z into evaluation, and adds a test for Z-dependent rendering. |
| CHANGELOG.md | Documents the new RenderConfig.z API surface. |
Suppressed comments (2)
fidget-raster/src/pixel.rs:555
RenderConfig::runreturnsImage(notOption/Result), so calling.unwrap()here won’t compile. Remove the unwrap and terminate the method chain with a semicolon.
}
.run(shape.clone().try_into().expect("no vars"))
fidget-raster/src/pixel.rs:565
RenderConfig::runreturnsImage(notOption/Result), so calling.unwrap()here won’t compile. Remove the unwrap and terminate the method chain with a semicolon.
}
.run(shape.try_into().expect("no vars"))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #444