Skip to content

Add Z to fidget::raster::pixel::RenderConfig - #445

Merged
mkeeter merged 1 commit into
mainfrom
pixel-set-z
Aug 4, 2026
Merged

Add Z to fidget::raster::pixel::RenderConfig#445
mkeeter merged 1 commit into
mainfrom
pixel-set-z

Conversation

@mkeeter

@mkeeter mkeeter commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Fixes #444

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the 2D pixel rasterizer configuration to support rendering a slice at an arbitrary Z value (instead of always evaluating at Z=0), aligning with Issue #444.

Changes:

  • Add z: f32 to fidget::raster::pixel::RenderConfig with a default of 0.0.
  • Thread the configured Z value through interval- and bulk-evaluation paths (Worker scratch buffers and interval bounds).
  • Add a unit test validating inside/outside behavior across different Z values, and update the changelog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
fidget-raster/src/pixel.rs Adds RenderConfig.z, propagates Z into evaluation, and adds a test for Z-dependent rendering.
CHANGELOG.md Documents the new RenderConfig.z API surface.
Suppressed comments (2)

fidget-raster/src/pixel.rs:555

  • RenderConfig::run returns Image (not Option/Result), so calling .unwrap() here won’t compile. Remove the unwrap and terminate the method chain with a semicolon.
        }
        .run(shape.clone().try_into().expect("no vars"))

fidget-raster/src/pixel.rs:565

  • RenderConfig::run returns Image (not Option/Result), so calling .unwrap() here won’t compile. Remove the unwrap and terminate the method chain with a semicolon.
        }
        .run(shape.try_into().expect("no vars"))

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread fidget-raster/src/pixel.rs Outdated
Comment thread CHANGELOG.md
@mkeeter
mkeeter enabled auto-merge (squash) August 4, 2026 00:54
@mkeeter
mkeeter merged commit e586cf6 into main Aug 4, 2026
14 checks passed
@mkeeter
mkeeter deleted the pixel-set-z branch August 4, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add z to fidget::raster::pixel::RenderConfig

2 participants