fix: flush oclif output buffers on error#1774
Open
gandie wants to merge 2 commits into
Open
Conversation
martin-helmich
requested changes
May 8, 2026
| setImmediate(async () => { | ||
| handle.unmount(); | ||
| process.exit(1); | ||
| import("@oclif/core").then(async (oclif) => { |
Member
There was a problem hiding this comment.
Import could be moved to the top of the module, I think.
martin-helmich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to narrow down #1323 even further, i've discovered some passages that might also need flushing, as well as one passage in
ExecRenderBaseCommandthat might cause trouble on buffered consoles. Not yet tried on windows machine yet, dev version working fine so far.Also relaxed cleanup pattern in
package.jsonas my cleanups were incomplete with the given one, confusing me when using dev tools mentioned in contribution guide (yarn compiledid not rebuilddistafteryarn clean, took some time to figure out root cause: thetsconfig.tsbuildinfofile was still present ).