Skip to content

fix: harden archive-changes workflow checkout#1685

Open
gilescope wants to merge 1 commit into
mainfrom
codex/vuln
Open

fix: harden archive-changes workflow checkout#1685
gilescope wants to merge 1 commit into
mainfrom
codex/vuln

Conversation

@gilescope

Copy link
Copy Markdown
Contributor

Quarantine the untrusted release ref to release-tree/ and source CI assets (install-season action, season.yml) from a separate default-branch checkout, so an arbitrary inputs.ref cannot execute code with the workflow's contents:write token. Disable credential persistence on both checkouts; the tag fetch authenticates explicitly via http.extraheader.

Assisted-by: Claude:claude-fable-5

Overview

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Quarantine the untrusted release ref to release-tree/ and source CI
assets (install-season action, season.yml) from a separate default-branch
checkout, so an arbitrary inputs.ref cannot execute code with the
workflow's contents:write token. Disable credential persistence on both
checkouts; the tag fetch authenticates explicitly via http.extraheader.

Assisted-by: Claude:claude-fable-5
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope requested a review from a team as a code owner June 11, 2026 16:47
@gilescope gilescope added skip-changes-check-all ai-assisted Created or modified with AI assistance labels Jun 11, 2026
@gilescope gilescope enabled auto-merge June 11, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Created or modified with AI assistance skip-changes-check-all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants