fix(ci): harden release workflow inputs#1684
Open
gilescope wants to merge 1 commit into
Open
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
6bc4ea2 to
ae28755
Compare
night-warden
approved these changes
Jun 11, 2026
justinfrevert
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runtime-tag-release/suffixvalue was being interpolated directly intorun:shell blocks, allowing shell metacharacters to be expanded before the shell runs and enabling command injection in privileged release jobs.Description
suffixin.github/workflows/release-image.ymland forruntime-tag-releasein.github/workflows/srtool-build.ymlto permit only letters, numbers, dots, underscores, and hyphens.${{ ... }}expressions directly insiderun:scripts by exporting derived srtool WASM filenames into environment variables (WASM_FILE,COMPACT_WASM_FILE,COMPRESSED_WASM_FILE) and then referencing those shell variables inside therun:blocks.matrix.platformusages intoenv: PLATFORM: ${{ matrix.platform }}and use$PLATFORMinsiderun:blocks so no${{ ... }}expressions appear in shell scripts.Testing
YAML.load_file) to ensure syntactic validity, which succeeded.${{ ... }}GitHub expressions remain insiderun:blocks for the touched workflows, which succeeded.git diff --checkto ensure no whitespace or diff issues, which succeeded, and notedactionlintwas not available in the environment so full linting could not be run locally.Codex Task