fix: honor rotated cnight cache config#1681
Open
gilescope wants to merge 1 commit into
Open
Conversation
Assisted-by: OpenAI:GPT-5.5
| &vec[a..b] | ||
| } | ||
|
|
||
| fn cnight_addresses_eq(left: &CNightAddresses, right: &CNightAddresses) -> bool { |
Contributor
There was a problem hiding this comment.
These sort of comparisons could be implemented in Eq or PartialEq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Arc<RwLock<CNightAddresses>>and record theCNightAddressesused for each same-tip memoized result so cached data is tied to the originating runtime config.sync_runtime_configto compare the per-call runtimeconfigto the cache's active config and, on mismatch, invalidate the in-memory window, clear the same-tip memoized result, and reset the cache anchor so the call falls back to the DB-backed source.configagainst the stored config and only reuse cached results when configs match, while preserving DB fallback behavior for out-of-window queries.changes/change file documenting the security fix.Testing
cargo fmt --checkand it succeeded.cargo check -p midnight-primitives-mainchain-followerand it succeeded.cargo test -p midnight-primitives-mainchain-follower sync_runtime_config_invalidates_window_for_rotated_cnight_configand it passed.cargo testfor the modified crate (unit tests) completed with the new test passing.Codex Task