fix: don't die if process exists but process.env doesn't#284
Merged
Conversation
Refs shikijs/shiki#735 Refs shikijs/shiki#474 Signed-off-by: Aarni Koskela <akx@iki.fi>
There was a problem hiding this comment.
Pull request overview
This PR hardens the DebugFlags.InDebugMode detection so the library doesn’t throw at module-evaluation time in environments where a process shim exists but process.env is missing/undefined (as reported by Shiki users).
Changes:
- Make access to
process.env['VSCODE_TEXTMATE_DEBUG']null-safe via optional chaining to avoidCannot read properties of undefinederrors.
Show a summary per file
| File | Description |
|---|---|
src/debug.ts |
Uses optional chaining when reading process.env to prevent runtime crashes when env is absent. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
alexdima
approved these changes
Jun 13, 2026
dmitrivMS
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs shikijs/shiki#474
Refs shikijs/shiki#735